Re: MI: fix base members in references

Nick Roberts
2006-12-05T21:25:42Z

> > Actually Vladimir's other patch, MI/C++/references fixup
> > (http://sourceware.org/ml/gdb-patches/2006-11/msg00373.html), seems to fix
> > this. As it also fixes the more general problem of updating references can
> > this not be applied instead?
>
> They can both go in as far as I'm concerned; I think they're both
> needed. I hadn't got to that one yet.

The comment in varobj.c refers to "Baseclass" and I presume the original author
included the case

TYPE_CODE (value_type (parent->value)) == TYPE_CODE_REF

for a specific reason.

If the patch (fix base members) is a reaction to the reported bug, it's seems
unnecessary with the other patch and therefore, I think it shouldn't be
applied. If you can see more generally that it's needed then thats another
matter, and clearly it should be applied.

--
Nick http://www.inet.net.nz/~nickrob