From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30013 invoked by alias); 17 Oct 2006 22:10:27 -0000 Received: (qmail 29999 invoked by uid 22791); 17 Oct 2006 22:10:26 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Oct 2006 22:10:21 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-216.snap.net.nz [202.124.120.216]) by viper.snap.net.nz (Postfix) with ESMTP id B40A37BAE17; Wed, 18 Oct 2006 11:10:13 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id C18D1BE444; Wed, 18 Oct 2006 11:07:18 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17717.21525.266502.810090@kahikatea.snap.net.nz> Date: Tue, 17 Oct 2006 22:10:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic In-Reply-To: <20061017215754.GA15210@nevyn.them.org> References: <17717.17922.450312.898237@kahikatea.snap.net.nz> <20061017213119.GA14010@nevyn.them.org> <17717.20397.279496.222573@kahikatea.snap.net.nz> <20061017215754.GA15210@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.50.26 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00202.txt.bz2 > > I have other changes but they're all older. I think that's it but I'll > > check more carefully. > > Well, it won't compile as-is, so obviously you haven't tested this > patch on its own :-) Oops, I forgot to look in the MI directory. -- Nick http://www.inet.net.nz/~nickrob *** mi-cmd-break.c 24 Dec 2005 07:57:46 +1300 1.13 --- mi-cmd-break.c 18 Oct 2006 02:54:07 +1300 *************** mi_cmd_break_insert (char *command, char *** 140,153 **** case REG_BP: rc = gdb_breakpoint (address, condition, 0 /*hardwareflag */ , temp_p, ! thread, ignore_count, ! &mi_error_message); break; case HW_BP: rc = gdb_breakpoint (address, condition, 1 /*hardwareflag */ , temp_p, ! thread, ignore_count, ! &mi_error_message); break; #if 0 case REGEXP_BP: --- 140,151 ---- case REG_BP: rc = gdb_breakpoint (address, condition, 0 /*hardwareflag */ , temp_p, ! thread, ignore_count); break; case HW_BP: rc = gdb_breakpoint (address, condition, 1 /*hardwareflag */ , temp_p, ! thread, ignore_count); break; #if 0 case REGEXP_BP: