From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14913 invoked by alias); 17 Oct 2006 21:51:42 -0000 Received: (qmail 14896 invoked by uid 22791); 17 Oct 2006 21:51:36 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Oct 2006 21:51:31 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-216.snap.net.nz [202.124.120.216]) by viper.snap.net.nz (Postfix) with ESMTP id 7ECDA7BAB23; Wed, 18 Oct 2006 10:51:25 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 09E10BE444; Wed, 18 Oct 2006 10:48:30 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17717.20397.279496.222573@kahikatea.snap.net.nz> Date: Tue, 17 Oct 2006 21:51:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic In-Reply-To: <20061017213119.GA14010@nevyn.them.org> References: <17717.17922.450312.898237@kahikatea.snap.net.nz> <20061017213119.GA14010@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.50.26 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00196.txt.bz2 > > This patch fixes PR mi/2086. There may be similar bugs arising from using > > catch_exceptions_with_msg inappropriately. > > Is this the whole patch? I guess you updated the caller too. I have other changes but they're all older. I think that's it but I'll check more carefully. > I think removing catch_exceptions_with_msg isn't enough - if you look > at the call site, it's not prepared for an error() to escape there. > It would have to use a cleanup for deprecated_set_gdb_event_hooks. Heres my take: I think the problem arises from changes Andrew Cagney made on 2005-01-13. It worked before then but was probably a bit of a hack. By removing catch_exceptions_with_msg the error propagates back to catch_exception with the function argument captured_mi_execute_command: #14 0x0812fdf8 in catch_exception (uiout=0x8823918, func=0x80ca1e7 , func_args=0xbfc229a4, mask=6) at exceptions.c:469 #15 0x080ca5de in mi_execute_command (cmd=0x8855220 "-break-insert *", from_tty= (mi_execute_command was also changed on 2005-01-13). > Ulrich posted a detailed analysis of this to gdb@ on Oct. 4th. I think > it was just a buggy conversion to catch_exceptions_with_msg; we should > check everywhere touched by whatever patch that was. Looks like it was > from 2005-01-13. I'll take a look but I'm guessing 2086 might be less general. > > I could slowly work my way through the mi PRs in the bug database. Can I > > close a bug or is that another level? (I don't know my password, if I have > > one). > > I'll send it offlist. Feel free to close bugs. Thanks. -- Nick http://www.inet.net.nz/~nickrob