From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20735 invoked by alias); 17 Oct 2006 21:10:24 -0000 Received: (qmail 20687 invoked by uid 22791); 17 Oct 2006 21:10:24 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Oct 2006 21:10:15 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-216.snap.net.nz [202.124.120.216]) by viper.snap.net.nz (Postfix) with ESMTP id 1F4CB7BAFC9 for ; Wed, 18 Oct 2006 10:10:12 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 68593BE444; Wed, 18 Oct 2006 10:07:16 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17717.17922.450312.898237@kahikatea.snap.net.nz> Date: Tue, 17 Oct 2006 21:10:00 -0000 To: gdb-patches@sources.redhat.com Subject: [PATCH] PR mi/2086 -break-insert missing error diagnostic X-Mailer: VM 7.19 under Emacs 22.0.50.26 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00192.txt.bz2 This patch fixes PR mi/2086. There may be similar bugs arising from using catch_exceptions_with_msg inappropriately. I could slowly work my way through the mi PRs in the bug database. Can I close a bug or is that another level? (I don't know my password, if I have one). -- Nick http://www.inet.net.nz/~nickrob *** gdb.h 18 Dec 2005 11:33:59 +1300 1.5 --- gdb.h 18 Oct 2006 02:57:25 +1300 *************** *** 53,60 **** /* Create a breakpoint at ADDRESS (a GDB source and line). */ enum gdb_rc gdb_breakpoint (char *address, char *condition, int hardwareflag, int tempflag, ! int thread, int ignore_count, ! char **error_message); /* Switch thread and print notification. */ enum gdb_rc gdb_thread_select (struct ui_out *uiout, char *tidstr, --- 53,59 ---- /* Create a breakpoint at ADDRESS (a GDB source and line). */ enum gdb_rc gdb_breakpoint (char *address, char *condition, int hardwareflag, int tempflag, ! int thread, int ignore_count); /* Switch thread and print notification. */ enum gdb_rc gdb_thread_select (struct ui_out *uiout, char *tidstr, *** breakpoint.c 09 Aug 2006 09:32:37 +1200 1.229 --- breakpoint.c 18 Oct 2006 03:04:02 +1300 *************** do_captured_breakpoint (struct ui_out *u *** 5466,5473 **** enum gdb_rc gdb_breakpoint (char *address, char *condition, int hardwareflag, int tempflag, ! int thread, int ignore_count, ! char **error_message) { struct captured_breakpoint_args args; args.address = address; --- 5466,5472 ---- enum gdb_rc gdb_breakpoint (char *address, char *condition, int hardwareflag, int tempflag, ! int thread, int ignore_count) { struct captured_breakpoint_args args; args.address = address; *************** gdb_breakpoint (char *address, char *con *** 5476,5483 **** args.tempflag = tempflag; args.thread = thread; args.ignore_count = ignore_count; ! return catch_exceptions_with_msg (uiout, do_captured_breakpoint, &args, ! error_message, RETURN_MASK_ALL); } --- 5475,5481 ---- args.tempflag = tempflag; args.thread = thread; args.ignore_count = ignore_count; ! return do_captured_breakpoint (uiout, &args); }