From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16406 invoked by alias); 13 Oct 2006 19:15:07 -0000 Received: (qmail 16398 invoked by uid 22791); 13 Oct 2006 19:15:06 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 13 Oct 2006 19:15:01 +0000 Received: from kahikatea.snap.net.nz (p202-124-120-198.snap.net.nz [202.124.120.198]) by viper.snap.net.nz (Postfix) with ESMTP id 15C037BADE4; Sat, 14 Oct 2006 08:14:54 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id B653ABE3F1; Sat, 14 Oct 2006 08:12:05 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17711.58627.807819.705317@kahikatea.snap.net.nz> Date: Fri, 13 Oct 2006 19:15:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: Async patch (no. 3) In-Reply-To: <20061013131118.GA8144@nevyn.them.org> References: <17711.20298.658015.189122@kahikatea.snap.net.nz> <20061013131118.GA8144@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.50.25 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00157.txt.bz2 > I'm agreeable in principle, though I don't have time to review it as > well as I'd like at the moment. Thank you for all your hard work on > this! I'll try hard to make the time. Thanks. There's no great urgency on my part, I just need it for after Emacs release. It's about to go to pretest but this will probably be a drawn out process if the two and a half year feature freeze is anything to go by. > I think you will need to add new target_ops methods; probably one to > set up async waiting and another to clean up afterwards. There > shouldn't be any reference to SIGCHLD directly in the common files (I'm > thinking about how to make this work on Windows, you see). OK, I'll try that. In the meantime, I've noticed that the patch forces GDB to run synchronously. In target.c, update_current_target must be made to inherit async methods again. This means that server-run.exp still doesn't work (and probably any test which changes to a synchronous target). I'll include this when I submit a cleaned up patch. -- Nick http://www.inet.net.nz/~nickrob