From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76967 invoked by alias); 16 Oct 2017 22:01:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76955 invoked by uid 89); 16 Oct 2017 22:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=expressly, Hx-languages-length:1163 X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 22:01:27 +0000 Received: by mail-wm0-f53.google.com with SMTP id k4so152548wmc.1 for ; Mon, 16 Oct 2017 15:01:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HLBxvsqew1VP/UuKNWxvT7bi+ig8hthOCLDDfkr+eCQ=; b=L3mp7cQEwl8kGP/XGzvM+b/p7tsQGdN9WHWgSkkcgFDNkVo5y0vfem8MsoPuJYTtGx aDPuxPtBuHQ4y6UCd94ZTapUnwqtccmu/HEHBJ9h586ObmUfvevMnmVrVAVb4m+ZhlHK fMN8Of4nuOSo0qJW7fbrio5wKctUGKMvizCm7bMHnymmq+Nqf93Mqs7b/y1jPjpRzpVz g48W902ms6uhSxImVq2DG165wySSvuXvGGpQzn1tz3lt4dj1clMqkAWZ2C4OaeT63ggU JWySHB/o3ZT8SWawZQR9+Iiz+kQFmjEagxBVS9ZIU73ZeCDLwpSUEb/vq85i9XmoqfYp qBTw== X-Gm-Message-State: AMCzsaWqcLi6HU2eAScSXYk3+3I/rXyZCZuaxr1ovWO2z2sngTSoCXuj 983AtrF3OVUw04t84UYOY8lX5k1es5I= X-Google-Smtp-Source: ABhQp+T+nlZLRHgJiSS2I5kBMAXMnSIZj/HNOYb02hTf8PG9ccNr9lEEf8EpXImTHZYN4HXBeckIEw== X-Received: by 10.28.92.133 with SMTP id q127mr1758002wmb.26.1508191284821; Mon, 16 Oct 2017 15:01:24 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id k44sm25764315wrf.10.2017.10.16.15.01.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 15:01:23 -0700 (PDT) Subject: Re: [python] Allow explicit locations in breakpoints. To: Simon Marchi , Keith Seitz , "gdb-patches@sourceware.org" References: <04ccc2c4-7827-eedc-d8db-a83a0167acb6@redhat.com> <58311250-9ab1-39d1-99b6-07478bc8c2ab@redhat.com> <4768c7ad-cc3d-5702-fa93-40e9760d4ee8@ericsson.com> <81f2b22a-ba79-cc7c-ee85-95d2d433a90e@ericsson.com> From: Phil Muldoon Message-ID: <1765bb88-8ab0-bdcd-8551-69f8dff3bcb9@redhat.com> Date: Mon, 16 Oct 2017 22:01:00 -0000 MIME-Version: 1.0 In-Reply-To: <81f2b22a-ba79-cc7c-ee85-95d2d433a90e@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00479.txt.bz2 On 16/10/17 22:25, Simon Marchi wrote: > >> For now, though, I'll add the keywords (as strings) in. This really >> prompts me to think we should rewrite the gdb.Breakpoint constructor >> to not use create_breakpoint and be more MI-like in the creation of >> breakpoints. > I'm not sure what you mean, MI uses create_breakpoint in mi_cmd_break_insert_1. > > Simon > Simon, My apologies, on reading back I see I was pretty vague. I meant to create an explicit location using "new_explicit_location" function as MI does in that function you mentioned instead of "string_to_event_location". Keith mentioned it in the original email, I think, and that "string_to_event_location" was designed expressly for the command-line invocation. I wanted to see if Keith's comment would work in a gdb.Breakpoint. The downside is, if we do that (use new_explicit_location), we won't be able to accept explicit locations in the spec keyword and only via specific line, function, source-file, etc keyword based instantiation. I'll hack on the patch tomorrow and try to decide which. I'll repost the patch soon. Cheers Phil