From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17129 invoked by alias); 16 Jul 2006 12:38:28 -0000 Received: (qmail 17120 invoked by uid 22791); 16 Jul 2006 12:38:27 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Jul 2006 12:38:25 +0000 Received: from kahikatea.snap.net.nz (p202-124-112-186.snap.net.nz [202.124.112.186]) by viper.snap.net.nz (Postfix) with ESMTP id B795A7766AD; Mon, 17 Jul 2006 00:38:21 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id C048E1D3550; Mon, 17 Jul 2006 00:37:07 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17594.13041.576361.598547@kahikatea.snap.net.nz> Date: Sun, 16 Jul 2006 12:38:00 -0000 To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: Testsuite failures In-Reply-To: <200607161142.k6GBgPGf020488@elgar.sibelius.xs4all.nl> References: <200607161142.k6GBgPGf020488@elgar.sibelius.xs4all.nl> X-Mailer: VM 7.19 under Emacs 22.0.50.37 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00181.txt.bz2 > I'm seeing some new testsuite failures on several OpenBSD machines: > > Running ../../../../src/gdb/gdb/testsuite/gdb.base/annota3.exp ... > FAIL: gdb.base/annota3.exp: run until main breakpoint (pattern 6) > FAIL: gdb.base/annota3.exp: send SIGUSR1 (pattern 5) > FAIL: gdb.base/annota3.exp: annotate ignore count change (pattern 3) > > I think these are caused by your last commit: > > 2006-07-13 Nick Roberts > > * annotate.c (annotate_frame_begin): Re-instate frame-begin > annotation for level 3 annotations. Yes. I forgot that there were tests for level 3 annotations. Sorry about that. > Here's a patch that adjusts the testsuite to deal with the re-instated > frame-begin annotation. Can you verify that this is indeed the > intended effect of your change? It looks good to me. Also annota3.exp in gdb.cp (patch attached). It might be easier to use the $hex variable but I couldn't get it to work. > Index: ChangeLog > from Mark Kettenis > > * gdb.base/annota3.exp: Adjust patterns for re-instated > frame-begin annotation. > > Index: gdb.base/annota3.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v > retrieving revision 1.7 > diff -u -p -r1.7 annota3.exp > --- gdb.base/annota3.exp 7 Mar 2006 15:23:32 -0000 1.7 > +++ gdb.base/annota3.exp 16 Jul 2006 11:41:02 -0000 > @@ -112,6 +112,7 @@ gdb_expect_list "breakpoint info" "$gdb_ > > # > # run to a break point will test: > +# annotate-frame-begin I don't think this comment should be added (it means nothing to me). > #exp_internal 1 >... -- Nick http://www.inet.net.nz/~nickrob *** annota3.exp 12 Mar 2006 19:42:40 +1300 1.5 --- annota3.exp 17 Jul 2006 00:20:54 +1200 *************** gdb_expect_list "first run until main br *** 96,102 **** "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 1\r\n" "\r\n" ! "Breakpoint 1, main \\(\\) at .*annota3.cc:25\r\n" "\r\n\032\032source.*annota3.cc:25:.*:beg:0x\[0-9a-z\]+\r\n" "\r\n\032\032stopped\r\n" } --- 96,104 ---- "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 1\r\n" "\r\n" ! "Breakpoint 1, " ! "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n" ! "main \\(\\) at .*annota3.cc:25\r\n" "\r\n\032\032source.*annota3.cc:25:.*:beg:0x\[0-9a-z\]+\r\n" "\r\n\032\032stopped\r\n" } *************** gdb_expect_list "second run until main b *** 164,170 **** "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 2\r\n" "\r\n" ! "Breakpoint 2, main \\(\\) at .*annota3.cc:22\r\n" "\r\n\032\032source.*annota3.cc:22:.*:beg:0x\[0-9a-z\]+\r\n" "\r\n\032\032stopped\r\n" } --- 166,174 ---- "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 2\r\n" "\r\n" ! "Breakpoint 2, " ! "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n" ! "main \\(\\) at .*annota3.cc:22\r\n" "\r\n\032\032source.*annota3.cc:22:.*:beg:0x\[0-9a-z\]+\r\n" "\r\n\032\032stopped\r\n" }