From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104282 invoked by alias); 10 Aug 2017 13:26:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99571 invoked by uid 89); 10 Aug 2017 13:24:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Aug 2017 13:24:57 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F201DC07F98C; Thu, 10 Aug 2017 13:24:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F201DC07F98C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 516898BA5E; Thu, 10 Aug 2017 13:24:53 +0000 (UTC) Subject: Re: [PATCH v2 2/3] Replace remaining cleanups in fbsd-nat.c. To: John Baldwin , gdb-patches@sourceware.org References: <20170809174754.49166-1-jhb@FreeBSD.org> <20170809174754.49166-3-jhb@FreeBSD.org> From: Pedro Alves Message-ID: <17564147-c872-8b13-097d-81f6dc3071c5@redhat.com> Date: Thu, 10 Aug 2017 13:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170809174754.49166-3-jhb@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00214.txt.bz2 On 08/09/2017 06:47 PM, John Baldwin wrote: > + gdb::unique_xmalloc_ptr lwps (XCNEWVEC (lwpid_t, nlwps)); > + lwpid_t lwp = lwps.get ()[i]; I was going to say: ~~~ Note that std::unique_ptr has an array version that avoids the get() in "lwps.get ()[i]". I.e., with: gdb::unique_xmalloc_ptr lwps (XCNEWVEC (lwpid_t, nlwps)); ^^ you can then write the more natural: lwpid_t lwp = lwps[i]; ~~~ ... but realized it doesn't work currently, because I missed adding an xfree_deleter array specialization. Fixed now: https://sourceware.org/ml/gdb-patches/2017-08/msg00212.html Thanks, Pedro Alves