From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19147 invoked by alias); 20 May 2006 04:24:19 -0000 Received: (qmail 19132 invoked by uid 22791); 20 May 2006 04:24:17 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 20 May 2006 04:23:30 +0000 Received: from kahikatea.snap.net.nz (p202-124-112-55.snap.net.nz [202.124.112.55]) by viper.snap.net.nz (Postfix) with ESMTP id 9C6907562CB; Sat, 20 May 2006 16:23:28 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 995AB1D3550; Sat, 20 May 2006 16:23:06 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17518.39336.538984.261434@kahikatea.snap.net.nz> Date: Sat, 20 May 2006 06:21:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -var-update X-Mailer: VM 7.19 under Emacs 22.0.50.12 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00424.txt.bz2 > > Anyway here's a patch that actually seems to work. I've taken code from > > c_val_print. Maybe there should be more checks and I've not tested > > varobj_set_value (-var-assign) yet, but I thought I'd sound out the > > genaral approcah first. > I think that in any case, you should add a function and call it, instead of > adding three identical code fragments. It's just for discussion, not a finalised patch for approval. > BTW, why coerce_ref is not suitable > here? coerce_ref ensures that the address is placed in the value's contents, not the actual value which is being referred to. -- Nick http://www.inet.net.nz/~nickrob