From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16853 invoked by alias); 4 May 2006 22:30:46 -0000 Received: (qmail 16840 invoked by uid 22791); 4 May 2006 22:30:46 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 May 2006 22:30:43 +0000 Received: from farnswood.snap.net.nz (p202-124-114-186.snap.net.nz [202.124.114.186]) by viper.snap.net.nz (Postfix) with ESMTP id 259B17569BE; Fri, 5 May 2006 10:30:37 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 627C1627ED; Thu, 4 May 2006 23:30:54 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17498.32925.650883.963202@farnswood.snap.net.nz> Date: Thu, 04 May 2006 22:30:00 -0000 To: "Jim Blandy" Cc: "Vladimir Prus" , gdb-patches@sources.redhat.com Subject: Re: Variable objects: references formatting In-Reply-To: <8f2776cb0605041032g54a2a015hb4b8535d5cff5795@mail.gmail.com> References: <17497.14121.225320.477428@farnswood.snap.net.nz> <8f2776cb0605031650o1cf451bex682613fd1434a110@mail.gmail.com> <17497.24251.518395.25087@farnswood.snap.net.nz> <8f2776cb0605041032g54a2a015hb4b8535d5cff5795@mail.gmail.com> X-Mailer: VM 7.19 under Emacs 22.0.50.43 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00050.txt.bz2 > > OK, if its a patch for -var-valuate-expression then perhaps the BOGUS > > comment could be removed as it seems to address this issue. > > I read the "BOGUS" comment as referring to the fact that we have to > specially trap structs and unions, instead of simply passing > everything through common_val_print. I don't think this patch affects > that "bogusness"; it just makes the workaround work better. I was guessing. I see that the check is for var->type, whereas perhaps val_print prints out children if var->val->type is a struct/class. But I don't know the relationship between the two and you're the expert in these matters. > (Are there any cases where common_val_print (and thus c_val_print) > prints the "{...}" we need automatically for us? Or is this code the > sole source of that behavior?) I don't really know much about that end of things yet. I've looked mainly at the mi directory and variable objects. -- Nick http://www.inet.net.nz/~nickrob