From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21347 invoked by alias); 4 May 2006 01:53:53 -0000 Received: (qmail 21185 invoked by uid 22791); 4 May 2006 01:53:52 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 May 2006 01:53:50 +0000 Received: from farnswood.snap.net.nz (p202-124-115-126.snap.net.nz [202.124.115.126]) by viper.snap.net.nz (Postfix) with ESMTP id DDF40756477; Thu, 4 May 2006 13:53:47 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 3C001627ED; Thu, 4 May 2006 02:54:04 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17497.24251.518395.25087@farnswood.snap.net.nz> Date: Thu, 04 May 2006 01:53:00 -0000 To: "Jim Blandy" Cc: "Vladimir Prus" , gdb-patches@sources.redhat.com Subject: Re: Variable objects: references formatting In-Reply-To: <8f2776cb0605031650o1cf451bex682613fd1434a110@mail.gmail.com> References: <17497.14121.225320.477428@farnswood.snap.net.nz> <8f2776cb0605031650o1cf451bex682613fd1434a110@mail.gmail.com> X-Mailer: VM 7.19 under Emacs 22.0.50.43 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00027.txt.bz2 > > There are som many things about this patch that I don't understand: > > I may have made a mistake in reviewing, but please don't be > elliptical: just say what you think is wrong. If I had understood what was wrong I would have said so. As I didn't I could only point out inconsistencies. > The patch is against an older version of varobj.c, and does seem to be > cut from a larger patch, but it applies, and given the surrounding > code in c_value_of_variable, and the behavior of c_val_print, the > general sense of the change seems correct. Have you tried creating > varobjs for values that are references to structs and displaying them, > which I think is the case actually being addressed? OK, if its a patch for -var-valuate-expression then perhaps the BOGUS comment could be removed as it seems to address this issue. I see a more serious error with references: they don't seem to disappear from the changelist with -var-update: -var-create - * q ^done,name="var1",numchild="1",type="tommy" (gdb) -var-create - * rq ^done,name="var2",numchild="1",type="tommy &" (gdb) -var-update * ^done,changelist=[{name="var2",in_scope="true",type_changed="false"}] (gdb) -var-update * ^done,changelist=[{name="var2",in_scope="true",type_changed="false"}] (gdb) -var-update * ^done,changelist=[{name="var2",in_scope="true",type_changed="false"}] -- Nick http://www.inet.net.nz/~nickrob