From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92701 invoked by alias); 29 Nov 2018 15:24:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92541 invoked by uid 89); 29 Nov 2018 15:24:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=urgency, purchased X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr10052.outbound.protection.outlook.com (HELO EUR02-HE1-obe.outbound.protection.outlook.com) (40.107.1.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 15:24:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z75VkPiWzv9ansHtEuHSqwiZdKyr9II5n5hNguXX4MI=; b=Iwf/MOrTSg8grtldzSQ42Fw+C9A/9RnKJpvRiZkB3YEZf9pYZOv6Nra5ujnfPZMQe6+tIUqg12Kg46+gRJFHu8sOZvyvDWHPjLq1djo39tg8n/AcgIBZEhkmDMRqUs4vH/3sGaWCb2laxEGhDn/0VUYiXsewpvU5TKjNia0wHXs= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2392.eurprd08.prod.outlook.com (10.172.250.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.16; Thu, 29 Nov 2018 15:24:06 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::fd61:f010:9962:229]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::fd61:f010:9962:229%8]) with mapi id 15.20.1382.017; Thu, 29 Nov 2018 15:24:06 +0000 From: Alan Hayward To: Pedro Alves CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] AArch64: Racy: Don't set empty set of hardware BPs/WPs on new thread Date: Thu, 29 Nov 2018 15:24:00 -0000 Message-ID: <1743E685-1A43-4147-8C2F-12E24CCA0846@arm.com> References: <20181120115602.30606-1-alan.hayward@arm.com> <53201c24-5947-c29e-85cc-eff8e6ece2d4@redhat.com> In-Reply-To: <53201c24-5947-c29e-85cc-eff8e6ece2d4@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <84789422BF567C40A6AD78445DEAF192@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00534.txt.bz2 DQoNCj4gT24gMjkgTm92IDIwMTgsIGF0IDE0OjMyLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMTEvMjAvMjAx OCAxMTo1NiBBTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gW05vdGU6IEkg aG9wZSB0byBldmVudHVhbGx5IGlzb2xhdGUgdGhlIGV4YWN0IGtlcm5lbC9o YXJkd2FyZSBpc3N1ZSBhbmQNCj4+IHJhaXNlIGEgYnVnIGVsc2V3aGVyZSBh Z2FpbnN0IHRoYXQuXQ0KPiANCj4gQW55IGx1Y2sgd2l0aCB0aGF0IHNvIGZh cj8NCj4gDQo+IEEgZml4IHRoYXQgbWFrZXMgYSByYWNlIHdpbmRvdyBhIGJp dCBuYXJyb3dlciwgd2hpbGUgc3RpbGwNCj4gbGVhdmluZyBpdCBvcGVuLCBy aXNrcyBwdXNoaW5nIGRvd24gLyBkZWxheWluZyBhIHByb3BlciBmaXgsDQo+ IHBhcGVyaW5nIG92ZXIgdGhlIGlzc3VlLCBhbmQgbWFraW5nIHRoZSBidWcg aGFyZGVyIHRvIHJlcHJvZHVjZS4NCj4gQnV0IEkgd29uJ3Qgb2JqZWN0LCBl c3BlY2lhbGx5IHNpbmNlIHRoaXMgc2VlbXMgdG8gcmVkdWNlIG51bWJlcg0K PiBvZiBzeXNjYWxscyBnZGIgaXNzdWVzLCBzbyBjb3VsZCBiZSBzZWVuIGFz IG9wdGltaXphdGlvbiBhbmQNCj4gZ29vZCB0aGluZyBvbiBpdHMgb3duLg0K PiANCg0KSGVyZeKAmXMgd2hlcmUgaXQgZ2V0cyBtb3JlIGludGVyZXN0aW5n Li4uDQpXZSByZWNlbnRseSBnb3Qgc29tZSBuZXdseSBwdXJjaGFzZWQgYm94 ZXMgb2YgKGFsbGVnZWRseSkgdGhlIHNhbWUgaGFyZHdhcmUuIFdpdGgNCnRo ZSBzYW1lIGtlcm5lbCB2ZXJzaW9ucyBpbnN0YWxsZWQsIGlkZW50aWNhbCBn ZGIgYmluYXJ5LCBhbmQgc2FtZSB2ZXJzaW9ucyBvZiB0aGUNCmxpbmtlZCBs aWJyYXJpZXMsIHRoaXMgcmFjeSBiZWhhdmlvdXIgZG9lc27igJl0IGhhcHBl bi4NCg0KSWRlYWxseSwgbXkgbmV4dCBzdGVwIHdvdWxkIGJlIHRvIGdldCBv bmUgb2YgdGhlIG9sZGVyIGJveGVzIHJlLWltYWdlZCBpbiBleGFjdGx5DQp0 aGUgc2FtZSB3YXkgYXMgdGhlIG5ld2VyIGJveGVzIGFuZCBzZWUgaWYgdGhl IGlzc3VlIHZhbmlzaGVzIChvciBub3QpLiBTYWRseSwNCnRoYXTigJlzIG5v dCBwb3NzaWJsZSByaWdodCBub3cgKGl04oCZcyBhIHNoYXJlZCByZXNvdXJj ZSkuIE9uY2UgdGhleSBmcmVlIHVwIEnigJlsbA0KYmUgYWJsZSB0byBpbnZl c3RpZ2F0ZSBtb3JlLiBBbHNvLCBpZiB3ZSBjYW7igJl0IHJlcHJvZHVjZSBv biBuZXdlciBoYXJkd2FyZSB0aGVuDQppdCBsb3dlcnMgdGhlIHVyZ2VuY3kg ZG93biBteSB0b2RvIGxpc3QgYSBiaXQgdG9vLg0KDQoNCj4gTEdUTSwgd2l0 aCBuaXRzIGJlbG93IGFkZHJlc3NlZC4NCj4gDQo+PiANCj4+IE9uIHNvbWUg aGVhdmlseSBsb2FkZWQgQUFyY2g2NCBib3hlcywgR0RCIHdpbGwgc29tZXRp bWVzIGhhbmcgZm9yZXZlciB3aGVuDQo+PiB0aGUgaW5mZXJpb3IgY3JlYXRl cyBhIHRocmVhZC4gIFRoaXMgaGFuZyBoYXBwZW5zIGluc2lkZSB0aGUga2Vy bmVsIGR1cmluZw0KPj4gdGhlIHB0cmFjZSBjYWxsIHRvIHNldCBoYXJkd2Fy ZSB3YXRjaHBvaW50cyBvciBoYXJkd2FyZSBicmVha3BvaW50cy4NCj4+IEN1 cnJlbnRseSwgR0RCIHdpbGwgYWx3YXlzIHNldCBodyB3cC9icCBhdCB0aGUg c3RhcnQgb2YgZWFjaCB0aHJlYWQgZXZlbiBpZg0KPj4gdGhlcmUgYXJlIG5v bmUgc2V0IGluIHRoZSBwcm9jZXNzLg0KPj4gDQo+PiBUaGlzIHBhdGNoIHdv cmtzIGFyb3VuZCB0aGUgaXNzdWUgYnkgYXZvaWRpbmcgc2V0dGluZyBodyB3 cC9icCBpZiB0aGVyZQ0KPj4gYXJlIG5vbmUgc2V0IGZvciB0aGUgcHJvY2Vz cy4NCj4+IA0KPj4gT24gYW4gZWZmZWN0ZWQgbWFjaGluZSwgdGhpcyBmaXgg ZHJhc3RpY2FsbHkgcmVkdWNlcyB0aGUgcmFjeSBuYXR1cmUgb2YgdGhlDQo+ PiBnZGIudGhyZWFkcyB0ZXN0IHNldC4gIEkgcmFuIHRoZSBlbnRpcmUgZ2Ri IHRlc3Qgc3VpdGUgYWNyb3NzIGFsbCBwcm9jZXNzb3JzDQo+PiBmb3IgMTAw IGl0ZXJhdGlvbnMsIHRoZW4gcmFuIHRoZSByZXN1bHRzIHRocm91Z2ggdGhl IHJhY3kgdGVzdHMgc2NyaXB0Lg0KPj4gV2l0aG91dCB0aGUgcGF0Y2gsIDU4 IC5leHAgZmlsZXMgaW4gZ2RiLnRocmVhZHMgd2VyZSBtYXJrZWQgYXMgcmFj eS4gQWZ0ZXINCj4+IHRoZSBwYXRjaCB0aGlzIHJlZHVjZWQgdG8gdGhlIHNh bWUgfjE0IHRlc3RzIGFzIHRoZSBub24gZWZmZWN0ZWQgYm94ZXMuDQo+PiAN Cj4+IENsZWFybHkgR0RCIHdpbGwgc3RpbGwgYmUgc3ViamVjdCB0byBoYW5n cyBvbiBhbiBlZmZlY3QgYm94IGlmIGh3IHdwL2JwJ3MgYXJlDQo+PiB1c2Vk IHByaW9yIHRvIGNyZWF0aW5nIGluZmVyaW9yIHRocmVhZHMgb24gYSBoZWF2 aWx5IGxvYWRlZCBzeXN0ZW0uDQo+PiANCj4+IFRvIGVuYWJsZSB0aGlzIGlu IGdkYnNlcnZlciwgdGhlIHNlcXVlbmNlIGluIGdkYnNlcnZlciBhZGRfbHdw KCkgaXMgc3dpdGNoZWQNCj4+IHRvIHRoZSBzYW1lIGFzIGdkYiBvcmRlciBh cyBnZGIsIHRvIGVuc3VyZSB0aGUgdGhyZWFkIGlzIHJlZ2lzdGVyZWQgYmVm b3JlDQo+PiBjYWxsaW5nIG5ld190aHJlYWQoKS4gIFRoaXMgYWxsb3dzIGFh cmNoNjRfbGludXhfbmV3X3RocmVhZCgpIHRvIHJlYWQgdGhlDQo+PiBwdGlk Lg0KPj4gDQo+PiBnZGIvQ2hhbmdlTG9nOg0KPj4gDQo+PiAyMDE4LTExLTIw ICBBbGFuIEhheXdhcmQgIDxhbGFuLmhheXdhcmRAYXJtLmNvbT4NCj4+IA0K Pj4gCSogbmF0L2FhcmNoNjQtbGludXgtaHctcG9pbnQuYw0KPj4gCShhYXJj aDY0X2xpbnV4X2FueV9zZXRfZGVidWdfcmVnc19zdGF0ZSk6IE5ldyBmdW5j dGlvbi4NCj4+IAkqIG5hdC9hYXJjaDY0LWxpbnV4LWh3LXBvaW50LmgNCj4+ IAkoYWFyY2g2NF9saW51eF9hbnlfc2V0X2RlYnVnX3JlZ3Nfc3RhdGUpOiBO ZXcgZGVjbGFyYXRpb24uDQo+PiAJKiBuYXQvYWFyY2g2NC1saW51eC5jIChh YXJjaDY0X2xpbnV4X25ld190aHJlYWQpOiBDaGVjayBpZiBhbnkNCj4+IAlC UHMgb3IgV1BzIGFyZSBzZXQuDQo+PiANCj4+IGdkYi9nZGJzZXJ2ZXIvQ2hh bmdlTG9nOg0KPj4gDQo+PiAyMDE4LTExLTIwICBBbGFuIEhheXdhcmQgIDxh bGFuLmhheXdhcmRAYXJtLmNvbT4NCj4+IA0KPj4gCSogbGludXgtbG93LmMg KGFkZF9sd3ApOiBTd2l0Y2ggb3JkZXJpbmcuDQo+PiAtLS0NCj4+IGdkYi9n ZGJzZXJ2ZXIvbGludXgtbG93LmMgICAgICAgIHwgIDQgKystLQ0KPj4gZ2Ri L25hdC9hYXJjaDY0LWxpbnV4LWh3LXBvaW50LmMgfCAyMyArKysrKysrKysr KysrKysrKysrKysrKw0KPj4gZ2RiL25hdC9hYXJjaDY0LWxpbnV4LWh3LXBv aW50LmggfCAgNiArKysrKysNCj4+IGdkYi9uYXQvYWFyY2g2NC1saW51eC5j ICAgICAgICAgIHwgMTUgKysrKysrKysrKy0tLS0tDQo+PiA0IGZpbGVzIGNo YW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+PiAN Cj4+IGRpZmYgLS1naXQgYS9nZGIvZ2Ric2VydmVyL2xpbnV4LWxvdy5jIGIv Z2RiL2dkYnNlcnZlci9saW51eC1sb3cuYw0KPj4gaW5kZXggNzAxZjNlODYz Yy4uMWMzMzZlZmFkZSAxMDA2NDQNCj4+IC0tLSBhL2dkYi9nZGJzZXJ2ZXIv bGludXgtbG93LmMNCj4+ICsrKyBiL2dkYi9nZGJzZXJ2ZXIvbGludXgtbG93 LmMNCj4+IEBAIC05NTEsMTEgKzk1MSwxMSBAQCBhZGRfbHdwIChwdGlkX3Qg cHRpZCkNCj4+IA0KPj4gICBsd3AtPndhaXRzdGF0dXMua2luZCA9IFRBUkdF VF9XQUlUS0lORF9JR05PUkU7DQo+PiANCj4+ICsgIGx3cC0+dGhyZWFkID0g YWRkX3RocmVhZCAocHRpZCwgbHdwKTsNCj4+ICsNCj4+ICAgaWYgKHRoZV9s b3dfdGFyZ2V0Lm5ld190aHJlYWQgIT0gTlVMTCkNCj4+ICAgICB0aGVfbG93 X3RhcmdldC5uZXdfdGhyZWFkIChsd3ApOw0KPj4gDQo+PiAtICBsd3AtPnRo cmVhZCA9IGFkZF90aHJlYWQgKHB0aWQsIGx3cCk7DQo+PiAtDQo+PiAgIHJl dHVybiBsd3A7DQo+PiB9DQo+PiANCj4+IGRpZmYgLS1naXQgYS9nZGIvbmF0 L2FhcmNoNjQtbGludXgtaHctcG9pbnQuYyBiL2dkYi9uYXQvYWFyY2g2NC1s aW51eC1ody1wb2ludC5jDQo+PiBpbmRleCAxOGI1YWYyZDQ5Li43Zjk2ZmEy YjdhIDEwMDY0NA0KPj4gLS0tIGEvZ2RiL25hdC9hYXJjaDY0LWxpbnV4LWh3 LXBvaW50LmMNCj4+ICsrKyBiL2dkYi9uYXQvYWFyY2g2NC1saW51eC1ody1w b2ludC5jDQo+PiBAQCAtNzE3LDYgKzcxNywyOSBAQCBhYXJjaDY0X2xpbnV4 X3NldF9kZWJ1Z19yZWdzIChzdHJ1Y3QgYWFyY2g2NF9kZWJ1Z19yZWdfc3Rh dGUgKnN0YXRlLA0KPj4gICAgIH0NCj4+IH0NCj4+IA0KPj4gKy8qIFNlZSBu YXQvYWFyY2g2NC1saW51eC1ody1wb2ludC5oLiAgKi8NCj4+ICsNCj4+ICti b29sDQo+PiArYWFyY2g2NF9saW51eF9hbnlfc2V0X2RlYnVnX3JlZ3Nfc3Rh dGUgKHN0cnVjdCBhYXJjaDY0X2RlYnVnX3JlZ19zdGF0ZSAqc3RhdGUsDQo+ PiArCQkJCQlib29sIHdhdGNocG9pbnQpDQo+PiArew0KPj4gKyAgaW50IGks IGNvdW50Ow0KPj4gKyAgY29uc3QgQ09SRV9BRERSICphZGRyOw0KPj4gKyAg Y29uc3QgdW5zaWduZWQgaW50ICpjdHJsOw0KPj4gKw0KPj4gKyAgY291bnQg PSB3YXRjaHBvaW50ID8gYWFyY2g2NF9udW1fd3BfcmVncyA6IGFhcmNoNjRf bnVtX2JwX3JlZ3M7DQo+PiArICBhZGRyID0gd2F0Y2hwb2ludCA/IHN0YXRl LT5kcl9hZGRyX3dwIDogc3RhdGUtPmRyX2FkZHJfYnA7DQo+PiArICBjdHJs ID0gd2F0Y2hwb2ludCA/IHN0YXRlLT5kcl9jdHJsX3dwIDogc3RhdGUtPmRy X2N0cmxfYnA7DQo+PiArICBpZiAoY291bnQgPT0gMCkNCj4+ICsgICAgcmV0 dXJuIGZhbHNlOw0KPj4gKw0KPj4gKyAgZm9yIChpID0gMDsgaSA8IGNvdW50 OyBpKyspDQo+IA0KPiBZb3UgY291bGQgZGVjbGFyZStpbml0aWFsaXplIGF0 IHRoZSBzYW1lIHRpbWUuICBJLmUuOg0KPiANCj4gIGludCBjb3VudCA9IHdh dGNocG9pbnQgPyBhYXJjaDY0X251bV93cF9yZWdzIDogYWFyY2g2NF9udW1f YnBfcmVnczsNCj4gIGlmIChjb3VudCA9PSAwKQ0KPiAgICByZXR1cm4gZmFs c2U7DQo+IA0KPiAgQ09SRV9BRERSICphZGRyID0gd2F0Y2hwb2ludCA/IHN0 YXRlLT5kcl9hZGRyX3dwIDogc3RhdGUtPmRyX2FkZHJfYnA7DQo+ICB1bnNp Z25lZCBpbnQgY3RybCA9IHdhdGNocG9pbnQgPyBzdGF0ZS0+ZHJfY3RybF93 cCA6IHN0YXRlLT5kcl9jdHJsX2JwOw0KPiANCj4gIGZvciAoaW50IGkgPSAw OyBpIDwgY291bnQ7IGkrKykNCg0KQWdyZWVkLiBUaGlzIHdhcyBkdWUgdG8g bWUgY29weWluZyBmcm9tIGFhcmNoNjRfbGludXhfc2V0X2RlYnVnX3JlZ3Mg YW5kIGp1c3QNCmtlZXBpbmcgdG8gdGhlIGV4aXN0aW5nIHN0eWxlLg0KDQo+ IA0KPiANCj4+IC0tLSBhL2dkYi9uYXQvYWFyY2g2NC1saW51eC1ody1wb2lu dC5oDQo+PiArKysgYi9nZGIvbmF0L2FhcmNoNjQtbGludXgtaHctcG9pbnQu aA0KPj4gQEAgLTE4Miw2ICsxODIsMTIgQEAgaW50IGFhcmNoNjRfaGFuZGxl X3dhdGNocG9pbnQgKGVudW0gdGFyZ2V0X2h3X2JwX3R5cGUgdHlwZSwgQ09S RV9BRERSIGFkZHIsDQo+PiB2b2lkIGFhcmNoNjRfbGludXhfc2V0X2RlYnVn X3JlZ3MgKHN0cnVjdCBhYXJjaDY0X2RlYnVnX3JlZ19zdGF0ZSAqc3RhdGUs DQo+PiAJCQkJICAgaW50IHRpZCwgaW50IHdhdGNocG9pbnQpOw0KPj4gDQo+ PiArLyogUmV0dXJuIFRSVUUgaWYgdGhlcmUgYXJlIGFueSBoYXJkd2FyZSBi cmVha3BvaW50cy4gIElmIFdBVENIUE9JTlQgaXMgVFJVRSwNCj4+ICsgICBj aGVjayBoYXJkd2FyZSB3YXRjaHBvaW50cyBpbnN0ZWFkLiAgKi8NCj4+ICti b29sDQo+PiArYWFyY2g2NF9saW51eF9hbnlfc2V0X2RlYnVnX3JlZ3Nfc3Rh dGUgKHN0cnVjdCBhYXJjaDY0X2RlYnVnX3JlZ19zdGF0ZSAqc3RhdGUsDQo+ PiArCQkJCQlib29sIHdhdGNocG9pbnQpOw0KPiANCj4gRnVuY3Rpb24gbmFt ZSBvbmx5IGdvZXMgb24gZmlyc3QgY29sdW1uIGluIGRlZmluaXRpb25zLg0K PiANCj4gU2VlIGUuZy4sIGV4dGVuc2lvbi5oOg0KPiANCj4gYm9vbCBhYXJj aDY0X2xpbnV4X2FueV9zZXRfZGVidWdfcmVnc19zdGF0ZQ0KPiAgKHN0cnVj dCBhYXJjaDY0X2RlYnVnX3JlZ19zdGF0ZSAqc3RhdGUsIGJvb2wgd2F0Y2hw b2ludCk7DQo+IA0KPiANCj4gT3IgeW91IGNvdWxkIGRyb3AgInN0cnVjdCIg dG8gZml0IHVuZGVyIDgwIGNvbHM6DQo+IA0KPiBib29sIGFhcmNoNjRfbGlu dXhfYW55X3NldF9kZWJ1Z19yZWdzX3N0YXRlIChhYXJjaDY0X2RlYnVnX3Jl Z19zdGF0ZSAqc3RhdGUsDQo+IAkJCQkJICAgICBib29sIHdhdGNocG9pbnQp Ow0KPiANCg0KT2suDQoNCg0KPiANCj4gDQo+PiArDQo+PiB2b2lkIGFhcmNo NjRfc2hvd19kZWJ1Z19yZWdfc3RhdGUgKHN0cnVjdCBhYXJjaDY0X2RlYnVn X3JlZ19zdGF0ZSAqc3RhdGUsDQo+PiAJCQkJICAgY29uc3QgY2hhciAqZnVu YywgQ09SRV9BRERSIGFkZHIsDQo+PiAJCQkJICAgaW50IGxlbiwgZW51bSB0 YXJnZXRfaHdfYnBfdHlwZSB0eXBlKTsNCj4+IGRpZmYgLS1naXQgYS9nZGIv bmF0L2FhcmNoNjQtbGludXguYyBiL2dkYi9uYXQvYWFyY2g2NC1saW51eC5j DQo+PiBpbmRleCAwZjJjODAxMWVhLi40OGM1OWY2Mjg4IDEwMDY0NA0KPj4g LS0tIGEvZ2RiL25hdC9hYXJjaDY0LWxpbnV4LmMNCj4+ICsrKyBiL2dkYi9u YXQvYWFyY2g2NC1saW51eC5jDQo+PiBAQCAtNzMsMTMgKzczLDE4IEBAIGFh cmNoNjRfbGludXhfcHJlcGFyZV90b19yZXN1bWUgKHN0cnVjdCBsd3BfaW5m byAqbHdwKQ0KPj4gdm9pZA0KPj4gYWFyY2g2NF9saW51eF9uZXdfdGhyZWFk IChzdHJ1Y3QgbHdwX2luZm8gKmx3cCkNCj4+IHsNCj4+ICsgIHB0aWRfdCBw dGlkID0gcHRpZF9vZl9sd3AgKGx3cCk7DQo+PiArICBzdHJ1Y3QgYWFyY2g2 NF9kZWJ1Z19yZWdfc3RhdGUgKnN0YXRlDQo+PiArICAgID0gYWFyY2g2NF9n ZXRfZGVidWdfcmVnX3N0YXRlIChwdGlkLnBpZCAoKSk7DQo+PiAgIHN0cnVj dCBhcmNoX2x3cF9pbmZvICppbmZvID0gWE5FVyAoc3RydWN0IGFyY2hfbHdw X2luZm8pOw0KPj4gDQo+PiAtICAvKiBNYXJrIHRoYXQgYWxsIHRoZSBoYXJk d2FyZSBicmVha3BvaW50L3dhdGNocG9pbnQgcmVnaXN0ZXIgcGFpcnMNCj4+ IC0gICAgIGZvciB0aGlzIHRocmVhZCBuZWVkIHRvIGJlIGluaXRpYWxpemVk ICh3aXRoIGRhdGEgZnJvbQ0KPj4gLSAgICAgYWFyY2hfcHJvY2Vzc19pbmZv LmRlYnVnX3JlZ19zdGF0ZSkuICAqLw0KPj4gLSAgRFJfTUFSS19BTExfQ0hB TkdFRCAoaW5mby0+ZHJfY2hhbmdlZF9icCwgYWFyY2g2NF9udW1fYnBfcmVn cyk7DQo+PiAtICBEUl9NQVJLX0FMTF9DSEFOR0VEIChpbmZvLT5kcl9jaGFu Z2VkX3dwLCBhYXJjaDY0X251bV93cF9yZWdzKTsNCj4+ICsgIC8qIElmIHRo ZXJlIGFyZSBoYXJkd2FyZSBicmVha3BvaW50cy93YXRjaHBvaW50cyBpbiB0 aGUgcHJvY2VzcyB0aGVuIG1hcmsgdGhhdA0KPj4gKyAgICAgYWxsIHRoZSBo YXJkd2FyZSBicmVha3BvaW50L3dhdGNocG9pbnQgcmVnaXN0ZXIgcGFpcnMg Zm9yIHRoaXMgdGhyZWFkIG5lZWQNCj4+ICsgICAgIHRvIGJlIGluaXRpYWxp emVkICh3aXRoIGRhdGEgZnJvbSBhYXJjaF9wcm9jZXNzX2luZm8uZGVidWdf cmVnX3N0YXRlKS4gICovDQo+PiArICBpZiAoYWFyY2g2NF9saW51eF9hbnlf c2V0X2RlYnVnX3JlZ3Nfc3RhdGUgKHN0YXRlLCBmYWxzZSkpDQo+PiArICAg IERSX01BUktfQUxMX0NIQU5HRUQgKGluZm8tPmRyX2NoYW5nZWRfYnAsIGFh cmNoNjRfbnVtX2JwX3JlZ3MpOw0KPj4gKyAgaWYgKGFhcmNoNjRfbGludXhf YW55X3NldF9kZWJ1Z19yZWdzX3N0YXRlIChzdGF0ZSwgdHJ1ZSkpDQo+PiAr ICAgIERSX01BUktfQUxMX0NIQU5HRUQgKGluZm8tPmRyX2NoYW5nZWRfd3As IGFhcmNoNjRfbnVtX3dwX3JlZ3MpOw0KPj4gDQo+PiAgIGx3cF9zZXRfYXJj aF9wcml2YXRlX2luZm8gKGx3cCwgaW5mbyk7DQo+PiB9DQo+PiANCj4gDQo+ IFRoYW5rcywNCj4gUGVkcm8gQWx2ZXMNCg0KDQo= >From gdb-patches-return-152584-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Nov 29 15:42:55 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 104494 invoked by alias); 29 Nov 2018 15:42:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 101276 invoked by uid 89); 29 Nov 2018 15:42:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Philippe, 3149 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 15:42:06 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75A223084296; Thu, 29 Nov 2018 15:42:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A87176442A; Thu, 29 Nov 2018 15:42:03 +0000 (UTC) Subject: Re: [RFA] Fix leak in forward-search To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20181127233328.5164-1-philippe.waroquiers@skynet.be> From: Pedro Alves Message-ID: <3cf960b8-ff82-0670-fa90-c94d78573bfe@redhat.com> Date: Thu, 29 Nov 2018 15:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181127233328.5164-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00535.txt.bz2 Content-length: 1268 On 11/27/2018 11:33 PM, Philippe Waroquiers wrote: > Valgrind reports the below leak. > Fix the leak by using xrealloc, even for the first allocation, > as buf is static. > > ==29158== 5,888 bytes in 23 blocks are definitely lost in loss record 3,028 of 3,149 > ==29158== at 0x4C2BE2D: malloc (vg_replace_malloc.c:299) > ==29158== by 0x41B557: xmalloc (common-utils.c:44) > ==29158== by 0x60B7D9: forward_search_command(char const*, int) (source.c:1563) > ==29158== by 0x40BA68: cmd_func(cmd_list_element*, char const*, int) (cli-decode.c:1888) > ==29158== by 0x665300: execute_command(char const*, int) (top.c:630) > ... > > gdb/ChangeLog > 2018-11-28 Philippe Waroquiers > > * source.c (forward_search_command): Fix leak by using > xrealloc even for the first allocation in the loop, as buf > is static. At first sight it would seem like 'buf' was made static to avoid allocating a growing buffer for each command invocation. But then, if that were the case, then you'd want 'cursize' to be static as well. The patch is OK, but I think that replacing 'buf' and all that manual buffer growing with a non-static gdb::def_vector defined outside the outer loop would be even better. Thanks, Pedro Alves