From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127453 invoked by alias); 31 May 2018 14:58:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127327 invoked by uid 89); 31 May 2018 14:58:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 14:57:58 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 791224070491; Thu, 31 May 2018 14:57:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B25A12024CA4; Thu, 31 May 2018 14:57:56 +0000 (UTC) Subject: Re: [PATCH 5/8] Add aarch64 psuedo help functions To: Simon Marchi , Alan Hayward , gdb-patches@sourceware.org References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-6-alan.hayward@arm.com> <680d01bb-e6ec-3d9e-e8a8-29d7c7bbf530@ericsson.com> Cc: nd@arm.com From: Pedro Alves Message-ID: <173f7c0c-c237-0a12-154e-f8bfa8df79c9@redhat.com> Date: Thu, 31 May 2018 15:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <680d01bb-e6ec-3d9e-e8a8-29d7c7bbf530@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00858.txt.bz2 On 05/31/2018 01:06 PM, Simon Marchi wrote: >> +/* Inner version of aarch64_pseudo_read_value. */ >> + >> +static struct value * >> +aarch64_pseudo_read_value_2 (readable_regcache *regcache, int regnum_offset, >> + int regsize, struct value *result_value) > > It's not a big deal, but in other GDB parts we actually often use the _1 suffix > for the helper functions. > Also, I'd think "Helper for aarch64_pseudo_read_value." would be clearer, because "inner version" sounds a bit odd to me. > But otherwise, LGTM. To me too. Thanks, Pedro Alves