From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16868 invoked by alias); 9 Oct 2013 13:34:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16857 invoked by uid 89); 9 Oct 2013 13:34:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx4-phx2.redhat.com Received: from mx4-phx2.redhat.com (HELO mx4-phx2.redhat.com) (209.132.183.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 13:34:20 +0000 Received: from zmail14.collab.prod.int.phx2.redhat.com (zmail14.collab.prod.int.phx2.redhat.com [10.5.83.16]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r99DYJEa004090; Wed, 9 Oct 2013 09:34:19 -0400 Date: Wed, 09 Oct 2013 13:34:00 -0000 From: Kai Tietz To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Tom Tromey Message-ID: <173490856.4156973.1381325657769.JavaMail.root@redhat.com> In-Reply-To: <20131009131016.GA1603@host2.jankratochvil.net> References: <20131008183214.GB27355@host2.jankratochvil.net> <87li23fsym.fsf@fleche.redhat.com> <20131009131016.GA1603@host2.jankratochvil.net> Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00271.txt.bz2 ----- Original Message ----- > On Tue, 08 Oct 2013 21:44:33 +0200, Tom Tromey wrote: > > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> - if (result == NULL) > > Jan> + if (result != NULL) > > Jan> + fopen_e_ever_succeeded = 1; > > Jan> + else if (!fopen_e_ever_succeeded) > > > > What if we have it check for EINVAL instead? > > May one rely on MS-Windows fopen("","re") will fail with EINVAL if it fails > because of the "e" flag, Kai? It is in GDB function gdb_fopen_cloexec. Yes, it fails due the 'e' command in mode. Obviously this option isn't supported on Windows due there is no fork. The allowed options for mode-flag is dependent to runtime-version. The function (it is under the hood the _openfile routine, which handles this) returns EINVAL on any not supported mode-options. So yes, probing for EINVAL seems to me like a valid way to probe for valid arguments here. > original post: > [patch] Minor O_CLOEXEC optimization, "regression" fix > https://sourceware.org/ml/gdb-patches/2013-10/msg00233.html > > > Thanks, > Jan > Regards, Kai