From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71942 invoked by alias); 5 May 2017 19:51:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71264 invoked by uid 89); 5 May 2017 19:51:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*Ad:U*macro, Hx-languages-length:2044, materially X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 19:51:34 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 1421110A7DB; Fri, 5 May 2017 15:51:35 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Pedro Alves , "Maciej W. Rozycki" , Luis Machado Subject: Re: [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers. Date: Fri, 05 May 2017 19:51:00 -0000 Message-ID: <1732755.e2u3aPx1km@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <1615766.4Mx9RcRn3g@ralph.baldwin.cx> References: <20170412183727.22483-1-jhb@FreeBSD.org> <1615766.4Mx9RcRn3g@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00153.txt.bz2 On Friday, April 28, 2017 09:48:50 AM John Baldwin wrote: > On Friday, April 28, 2017 02:51:41 PM Pedro Alves wrote: > > On 04/27/2017 08:37 PM, Maciej W. Rozycki wrote: > > > On Thu, 27 Apr 2017, Pedro Alves wrote: > > > > > >>> The use of angle brackets with the latter variant is consistent with other > > >>> targets, so I might have just a slight preference for it, but I'll be > > >>> happy to accept input from other people. > > >> > > >> FWIW, I'd find using anything but when that's what > > >> GDB means to be making the port be gratuitously different. > > >> "" always means the same thing in gdb -- gdb knows > > >> the value materially exists, but it can't get at it for some > > >> reason (e.g., ptrace does not expose it, a core dump is trimmed, value > > >> not collect in a trace frame, etc.). > > > > > > If you think keeping the word the same across ports is essential, then > > > `' would be my second choice, at some aesthetical cost. > > > > I'm not sure that trying to come up with short > > variants of these special values manually is the best option. > > > > Another output you could see here is "". > > GDB prints that if GDB figures out the register is not saved > > in a frame (or if the DWARF indicates that, via DW_CFA_undefined). > > Unfortunately, even "" is too long for the 8 character field > for a 32-bit register value. One perhaps simple option would be to always > use the same table layout for 32-bit vs 64-bit (4 columns x 11 rows). It > would mean doubling the lines that 'info registers' shows on 32-bit MIPS, > but it would still fit in 24 lines and would probably simplify the > implementation. > > However, as you note, the primary goal is removing the error(), and I can > live with any format that is readable. Any other thoughts on "" vs "" vs always using the 64-bit table layout vs ? -- John Baldwin