From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3Ac2OrKvqWBgJQAAWB0awg (envelope-from ) for ; Sat, 22 May 2021 21:28:18 -0400 Received: by simark.ca (Postfix, from userid 112) id DFE401F11C; Sat, 22 May 2021 21:28:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B6761E813 for ; Sat, 22 May 2021 21:28:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F4093853809; Sun, 23 May 2021 01:28:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F4093853809 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621733297; bh=q/XnlVJ/0nvyNQAjO5X1aex986DMl/B7/5CmIqJBFyk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ORAoPBcC5BY6y/jbcOK1y3lgsEILH4hLvFuUXE+tVbkbQK8UYSwhmjnvYGA+GCwX1 Ztj8patwk2/n2RVpZYzC650e10MVPQzU9eYGcgIyhGM3Tfl/jDvfEQrN/lAdhB214y nvZ38ea2D1pSomZpHao6ZzpFbPTk9M5URa6q9LZs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5B80C3853809 for ; Sun, 23 May 2021 01:28:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B80C3853809 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14N1Rr1H004162 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 22 May 2021 21:27:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14N1Rr1H004162 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 734D81E813; Sat, 22 May 2021 21:27:52 -0400 (EDT) Subject: Re: [PATCH][gdb/tdep] Use pid to choose x86_64 process 64/32-bitness To: Tom de Vries , Alan Hayward References: <20210507084402.GA14817@delia> <977346CD-5DE9-49E0-A4C2-061792548857@arm.com> <187f89df-ff39-8522-1410-4c089c796698@polymtl.ca> <547E4B36-8597-46E9-9B5B-23B188BF896D@arm.com> Message-ID: <172a4491-d783-c851-9f5f-5c0f6ea98713@polymtl.ca> Date: Sat, 22 May 2021 21:27:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 23 May 2021 01:27:53 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Andreas Arnez , nd , "gdb-patches\\@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >> diff --git a/gdb/target.h b/gdb/target.h >> index d867a58e2a8..51139042691 100644 >> --- a/gdb/target.h >> +++ b/gdb/target.h >> @@ -841,7 +841,10 @@ struct target_ops >> /* Describe the architecture-specific features of this target. If >> OPS doesn't have a description, this should delegate to the >> "beneath" target. Returns the description found, or NULL if no >> - description was available. */ >> + description was available. This should return something that >> + describes a whole process, and if there are things that are >> + thread-specific, target_thread_architecture should be used for >> + that. */ Haha, that sounds like the way I said it, which is a bit too informal for a comment I think. Here's what I suggest: /* Describe the architecture-specific features of the current inferior. Returns the description found, or nullptr if no description was available. If some target features differ between threads, the description returned by read_description (and the resulting gdbarch) won't accurately describe all threads. In this case, the thread_architecture method can be used to obtain gdbarches that accurately describe each thread. */ The patch LGTM with that. Simon