Re: [PATCH] arm reversible : <phase_2_complete>

Yao Qi
2011-11-08T10:17:12Z

On 11/08/2011 02:01 PM, oza Pawandeep wrote:
> Yao >> This function is used to match opcode for instructions. Why don't
> you use bit operation (AND and OR) and logic operation to match
> instruction? Bit operation and logic operation are widely used in
> gdb. It is efficient and easy to read. I suggest to replace
> sbo_sbz by bit/logical operation when matching instruction.
>
>
> Oza >> I am not sure what you meant by re-writting sbo_sbz function.
> as there is already '&' and '!' and '>>' which all are bit operators.

I suggested to remove sbo_sbz function, to decode instructions with
macros bits/bit, and to match using if/else/switch etc.

Please reference arm_get_next_pc_raw, arm_process_displaced_insn and
thumb_process_displaced_insn to see how instructions are decoded and
matched.

--
Yao (é½å°§)