Re: [PATCH] arm reversible : <phase_2_complete>

Tom Tromey
2011-11-03T17:38:39Z

>>>>> "Petr" == Petr Hluzín <petr.hluzin@gmail.com> writes:

Petr> The guideline - which I think Tom was reffering to - is that
Petr> impossible states and coding bugs in gdb should trigger assertions
Petr> however user's input (no matter how malformed) should trigger warning
Petr> or error messages.

Yes, I think that rule makes the most sense.

Petr> Some situations are difficult to decide whether they are trigger-able
Petr> by user input or not.
Petr> If my code is not coded or intended to handle such situations I prefer
Petr> to kill the process (or whatever are assertions configured to do) and
Petr> get feedback from user.
Petr> I am not familiar with GDB customs, though. Tom?

I think crashing gdb should be limited to "can't happen" scenarios
arising from the internal logic.

Tripping across an unrecognized instruction or the like should just
result in an ordinary gdb error -- something the user can reasonably
recover from.

If the error message is informative enough about what went wrong, it
will result in a bug report :-)

Tom