From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28677 invoked by alias); 26 Sep 2005 04:43:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28640 invoked by uid 22791); 26 Sep 2005 04:42:53 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 26 Sep 2005 04:42:53 +0000 Received: from kahikatea.snap.net.nz (p67-tnt1.snap.net.nz [202.124.110.67]) by viper.snap.net.nz (Postfix) with ESMTP id E65DE688D0C; Mon, 26 Sep 2005 16:42:33 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id D7FD283F8; Mon, 26 Sep 2005 16:37:16 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17207.31483.737599.279225@kahikatea.snap.net.nz> Date: Mon, 26 Sep 2005 04:43:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Get make TAGS to work in gdb directory In-Reply-To: <20050926013855.GD22284@nevyn.them.org> References: <17200.36038.631429.268643@farnswood.snap.net.nz> <20050926013855.GD22284@nevyn.them.org> X-SW-Source: 2005-09/txt/msg00216.txt.bz2 Daniel Jacobowitz writes: > This doesn't match what you said above but tipped me off to the > problem; s/amdfbsd-nat.c/amd64fbsd-nat.c/ instead please. OK. > Also, removing CONFIG_OBS doesn't have quite the affect you wanted. > You've also lost anything else that configure can add e.g. > libunwind-frame.c. Would adding CONFIG_SRCS to TAGFILES_NO_SRCDIR > instead work? Yes, I think so. I've also corrected my earlier typo (CONFIG_OBJS). Nick 2005-09-26 Nick Roberts * Makefile.in (HFILES_NO_SRCDIR): Remove minimon.h, symfile-mem.h. (ALLDEPFILES) Correct typo amdfbsd-nat.c -> amd64fbsd-nat.c. Remove irix4-nat.c, m3-nat.c, mipsm3-nat.c, ns32k-tdep.c symm-tdep.c and symm-nat.c. (TAGFILES_NO_SRCDIR): Add CONFIG_SRCS. (DEPFILES): Remove CONFIG_OBS and include it explicitly where needed. *** Makefile.in 16 Sep 2005 18:00:51 +1200 1.753 --- Makefile.in 26 Sep 2005 16:35:01 +1200 *************** tui_winsource_h = $(srcdir)/tui/tui-wins *** 852,860 **** HFILES_NO_SRCDIR = bcache.h buildsym.h call-cmds.h coff-solib.h defs.h \ exceptions.h \ environ.h $(gdbcmd_h) gdb.h gdbcore.h \ ! gdb-stabs.h $(inferior_h) language.h minimon.h monitor.h \ objfiles.h parser-defs.h serial.h solib.h \ ! symfile.h symfile-mem.h stabsread.h target.h terminal.h typeprint.h \ xcoffsolib.h \ macrotab.h macroexp.h macroscope.h \ ada-lang.h c-lang.h f-lang.h \ --- 852,860 ---- HFILES_NO_SRCDIR = bcache.h buildsym.h call-cmds.h coff-solib.h defs.h \ exceptions.h \ environ.h $(gdbcmd_h) gdb.h gdbcore.h \ ! gdb-stabs.h $(inferior_h) language.h monitor.h \ objfiles.h parser-defs.h serial.h solib.h \ ! symfile.h stabsread.h target.h terminal.h typeprint.h \ xcoffsolib.h \ macrotab.h macroexp.h macroscope.h \ ada-lang.h c-lang.h f-lang.h \ *************** REMOTE_EXAMPLES = m68k-stub.c i386-stub. *** 881,896 **** # Makefile.in DEPFILES = $(TDEPFILES) $(SER_HARDWIRE) $(NATDEPFILES) \ ! $(REMOTE_OBS) $(SIM_OBS) $(CONFIG_OBS) SOURCES = $(SFILES) $(ALLDEPFILES) $(YYFILES) $(CONFIG_SRCS) # Don't include YYFILES (*.c) because we already include *.y in SFILES, # and it's more useful to see it in the .y file. TAGFILES_NO_SRCDIR = $(SFILES) $(HFILES_NO_SRCDIR) $(ALLDEPFILES) \ ! $(SUBDIR_CLI_SRCS) TAGFILES_WITH_SRCDIR = $(HFILES_WITH_SRCDIR) ! COMMON_OBS = $(DEPFILES) $(YYOBJ) \ version.o \ annotate.o \ auxv.o \ --- 881,896 ---- # Makefile.in DEPFILES = $(TDEPFILES) $(SER_HARDWIRE) $(NATDEPFILES) \ ! $(REMOTE_OBS) $(SIM_OBS) SOURCES = $(SFILES) $(ALLDEPFILES) $(YYFILES) $(CONFIG_SRCS) # Don't include YYFILES (*.c) because we already include *.y in SFILES, # and it's more useful to see it in the .y file. TAGFILES_NO_SRCDIR = $(SFILES) $(HFILES_NO_SRCDIR) $(ALLDEPFILES) \ ! $(CONFIG_SRCS) TAGFILES_WITH_SRCDIR = $(HFILES_WITH_SRCDIR) ! COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $(YYOBJ) \ version.o \ annotate.o \ auxv.o \ *************** TAGS: $(TAGFILES_NO_SRCDIR) $(TAGFILES_W *** 1232,1238 **** @etags $(srcdir)/$(DEPRECATED_TM_FILE) \ $(srcdir)/$(XM_FILE) \ $(srcdir)/$(NAT_FILE) \ ! `(for i in $(DEPFILES) $(TAGFILES_NO_SRCDIR); do \ echo $(srcdir)/$$i ; \ done ; for i in $(TAGFILES_WITH_SRCDIR); do \ echo $$i ; \ --- 1232,1238 ---- @etags $(srcdir)/$(DEPRECATED_TM_FILE) \ $(srcdir)/$(XM_FILE) \ $(srcdir)/$(NAT_FILE) \ ! `(for i in $(TAGFILES_NO_SRCDIR); do \ echo $(srcdir)/$$i ; \ done ; for i in $(TAGFILES_WITH_SRCDIR); do \ echo $$i ; \ *************** observer.inc: observer.sh doc/observer.t *** 1354,1360 **** lint: $(LINTFILES) $(LINT) $(INCLUDE_CFLAGS) $(LINTFLAGS) $(LINTFILES) \ ! `echo $(DEPFILES) | sed 's/\.o /\.c /g'` gdb.cxref: $(SFILES) cxref -I. $(SFILES) >gdb.cxref --- 1354,1360 ---- lint: $(LINTFILES) $(LINT) $(INCLUDE_CFLAGS) $(LINTFLAGS) $(LINTFILES) \ ! `echo $(DEPFILES) $(CONFIG_OBS) | sed 's/\.o /\.c /g'` gdb.cxref: $(SFILES) cxref -I. $(SFILES) >gdb.cxref *************** ALLDEPFILES = \ *** 1378,1384 **** alpha-tdep.c alpha-linux-tdep.c alphabsd-tdep.c alphanbsd-tdep.c \ alpha-osf1-tdep.c alphafbsd-tdep.c alpha-mdebug-tdep.c \ amd64-nat.c amd64-tdep.c \ ! amd64bsd-nat.c amdfbsd-nat.c amd64fbsd-tdep.c \ amd64nbsd-nat.c amd64nbsd-tdep.c \ amd64obsd-nat.c amd64obsd-tdep.c \ amd64-linux-nat.c amd64-linux-tdep.c \ --- 1378,1384 ---- alpha-tdep.c alpha-linux-tdep.c alphabsd-tdep.c alphanbsd-tdep.c \ alpha-osf1-tdep.c alphafbsd-tdep.c alpha-mdebug-tdep.c \ amd64-nat.c amd64-tdep.c \ ! amd64bsd-nat.c amd64fbsd-nat.c amd64fbsd-tdep.c \ amd64nbsd-nat.c amd64nbsd-tdep.c \ amd64obsd-nat.c amd64obsd-tdep.c \ amd64-linux-nat.c amd64-linux-tdep.c \ *************** ALLDEPFILES = \ *** 1408,1416 **** i386gnu-nat.c i386gnu-tdep.c \ ia64-linux-nat.c ia64-linux-tdep.c ia64-tdep.c \ inf-ptrace.c inf-ttrace.c \ ! infptrace.c inftarg.c irix4-nat.c irix5-nat.c \ libunwind-frame.c \ ! lynx-nat.c m3-nat.c \ m68hc11-tdep.c \ m32r-tdep.c \ m32r-linux-nat.c m32r-linux-tdep.c \ --- 1408,1416 ---- i386gnu-nat.c i386gnu-tdep.c \ ia64-linux-nat.c ia64-linux-tdep.c ia64-tdep.c \ inf-ptrace.c inf-ttrace.c \ ! infptrace.c inftarg.c irix5-nat.c \ libunwind-frame.c \ ! lynx-nat.c \ m68hc11-tdep.c \ m32r-tdep.c \ m32r-linux-nat.c m32r-linux-tdep.c \ *************** ALLDEPFILES = \ *** 1418,1431 **** m68kbsd-nat.c m68kbsd-tdep.c \ m68klinux-nat.c m68klinux-tdep.c \ m88k-tdep.c m88kbsd-nat.c \ - mcore-tdep.c \ mips-linux-nat.c mips-linux-tdep.c \ mips-irix-tdep.c \ ! mips-tdep.c mipsm3-nat.c mipsv4-nat.c \ mipsnbsd-nat.c mipsnbsd-tdep.c \ mips64obsd-nat.c mips64obsd-tdep.c \ nbsd-tdep.c \ ! ns32k-tdep.c solib-osf.c \ somread.c solib-som.c $(HPREAD_SOURCE) \ ppc-sysv-tdep.c ppc-linux-nat.c ppc-linux-tdep.c \ ppcnbsd-nat.c ppcnbsd-tdep.c \ --- 1418,1430 ---- m68kbsd-nat.c m68kbsd-tdep.c \ m68klinux-nat.c m68klinux-tdep.c \ m88k-tdep.c m88kbsd-nat.c \ mips-linux-nat.c mips-linux-tdep.c \ mips-irix-tdep.c \ ! mips-tdep.c mipsv4-nat.c \ mipsnbsd-nat.c mipsnbsd-tdep.c \ mips64obsd-nat.c mips64obsd-tdep.c \ nbsd-tdep.c \ ! solib-osf.c \ somread.c solib-som.c $(HPREAD_SOURCE) \ ppc-sysv-tdep.c ppc-linux-nat.c ppc-linux-tdep.c \ ppcnbsd-nat.c ppcnbsd-tdep.c \ *************** ALLDEPFILES = \ *** 1447,1453 **** sparc64-tdep.c sparc64fbsd-nat.c sparc64fbsd-tdep.c \ sparc64nbsd-nat.c sparc64nbsd-tdep.c sparc64obsd-tdep.c \ sparcnbsd-nat.c sparcnbsd-tdep.c sparcobsd-tdep.c \ - symm-tdep.c symm-nat.c \ v850-tdep.c \ vax-nat.c vax-tdep.c vaxbsd-nat.c vaxnbsd-tdep.c \ win32-nat.c \ --- 1446,1451 ----