From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50396 invoked by alias); 25 Jan 2020 16:50:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50382 invoked by uid 89); 25 Jan 2020 16:50:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 Jan 2020 16:50:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579971020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F2Afig2bS5XGFg+57sBkTurr/jU2QqrbJ1IQjO207C8=; b=erfwInq5ujAREmcbsm1avZzkxTHqW0VP6gKr0EXdlsU4ZCqcruKy+T9DEOZv0M4BX9DwMC uMFfliuhi79HX8ui0IHUsDMb+HgXWIvVs3ruA+LkDjkiICswiG9hQwbm7h9fltUSdwUiLo mtXszFbXI6c7ATm+gO6C+IABKd5FVKQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-o33INs0OM3iwE4k-lrlqCg-1; Sat, 25 Jan 2020 11:50:15 -0500 Received: by mail-wr1-f70.google.com with SMTP id y7so3235693wrm.3 for ; Sat, 25 Jan 2020 08:50:15 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:2327:23ca:3e56:ef5f? ([2001:8a0:f909:7b00:2327:23ca:3e56:ef5f]) by smtp.gmail.com with ESMTPSA id f16sm12611387wrm.65.2020.01.25.08.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jan 2020 08:50:13 -0800 (PST) Subject: Re: [PATCH] Move gdbserver to top level To: Tom Tromey References: <87d0bf45up.fsf@tromey.com> <7ceebbb7-b2f7-3d4a-1d8a-f31310badbe8@redhat.com> <874kwk8nz9.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <171a3144-af37-1c29-a2a4-c4cd7eaa14c0@redhat.com> Date: Sat, 25 Jan 2020 16:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <874kwk8nz9.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00840.txt.bz2 On 1/24/20 10:54 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This should really be done by sourcing a file in gdbserver/ > Pedro> If we do that, then the info about whether a system supports > Pedro> gdbserver is contained under gdbserver/, and does not > Pedro> require syncing with gcc whenever is changes. > > Good idea, I've made this change. Here's an updated patch. > > As before, I've removed the generated files. > > If you want to test it, it is in submit/move-gdbserver-to-top on my > github. Thanks! I poked at it a bit. I think this looks good, though I have a comment on the dependencies below. I think this should have a NEWS entry, given that it affects people building standalone gdbserver today. Do you have documentation changes queued? > 2020-01-19 Simon Marchi > > * remote-sim.c (gdbsim_target::wait): Return > diff --git a/MAINTAINERS b/MAINTAINERS > index 805f2e3ac43..5b8a4efbdf6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -41,7 +41,7 @@ config.guess; config.sub; readline/support/config.{sub,guess} > depcomp; mkinstalldirs > Send bug reports and patches to bug-automake@gnu.org. > > -gdb/; gdbsupport/; gnulib/; readline/; sim/; GDB's part of include/ > +gdb/; gdbserver/; gdbsupport/; gnulib/; readline/; sim/; GDB's part of include/ > GDB: http://www.gnu.org/software/gdb/ > Patches to gdb-patches@sourceware.org. > See also gdb/MAINTAINERS and sim/MAINTAINERS. > diff --git a/Makefile.def b/Makefile.def > index 253eb45ef14..de35083d81e 100644 > --- a/Makefile.def > +++ b/Makefile.def > @@ -114,6 +114,7 @@ host_modules= { module= zlib; no_install=true; no_check=true; > extra_configure_flags='@extra_host_zlib_configure_flags@';}; > host_modules= { module= gnulib; }; > host_modules= { module= gdbsupport; }; > +host_modules= { module= gdbserver; }; > host_modules= { module= gdb; }; > host_modules= { module= expect; }; > host_modules= { module= guile; }; > @@ -409,6 +410,12 @@ dependencies = { module=all-gdb; on=all-libdecnumber; }; > dependencies = { module=all-gdb; on=all-libtermcap; }; > dependencies = { module=all-gdb; on=all-libctf; }; > > +// Host modules specific to gdbserver. > +dependencies = { module=configure-gdbserver; on=all-intl; }; This surprised me, as I don't think gdbserver actually depends on intl currently? Might still be a good idea to actually enable it, but I was surprised from an "as pure as possible" perspective. > +// Depend on all-libiconv so that configure checks for iconv > +// functions will work. > +dependencies = { module=configure-gdbserver; on=all-libiconv; }; > + Likewise curious. Can you clarify where the configure checks come from? Locally I removed the intl and iconv dependencies and the resulting gdbserver (w/ make all-gdbserver) was identical byte for byte for me. Thanks, Pedro Alves