From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63568 invoked by alias); 25 Jan 2019 16:47:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63555 invoked by uid 89); 25 Jan 2019 16:47:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=accessible, H*r:Client, H*r:present, H*r:did X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Jan 2019 16:47:10 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id EEC7493B7D; Fri, 25 Jan 2019 16:47:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 723BB8BD40; Fri, 25 Jan 2019 16:47:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id DCE16911D; Fri, 25 Jan 2019 16:47:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 0/3] Normalize common includes To: Joel Brobecker , Tom Tromey Cc: gdb-patches@sourceware.org References: <20190123172954.24421-1-tom@tromey.com> <20190125041744.GC7566@adacore.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <1719ec3d-44d0-916a-66b0-eed56c0903fc@FreeBSD.org> Date: Fri, 25 Jan 2019 16:47:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190125041744.GC7566@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 723BB8BD40 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_SHORT(-0.94)[-0.944,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00550.txt.bz2 On 1/24/19 8:17 PM, Joel Brobecker wrote: >> I think the norm in gdb is to include files from common using >> "common/filename.h" -- but this is not enforced, because the Makefiles >> provide -I$(srcdir)/common. >> >> This series rewrites gdb to use the norm everywhere, and then removes >> the -I options. The bulk of the change was done by script. >> >> Let me know what you think. It would be better for this to go in (if >> it goes in) before the include sorting patch. > > I think it's a good idea indeed. It's immediately clearer to me when > I see #include "common/something.h". The downside is having to update > all the includes when we move one file, but I think this one-off > is worth the extra clarity. I think it is a good idea as well. It probably makes the codebase a bit more accessible to newcomers to have the explicit paths. -- John Baldwin                                                                            Â