From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23393 invoked by alias); 30 Jul 2005 22:47:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23385 invoked by uid 22791); 30 Jul 2005 22:47:39 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 30 Jul 2005 22:47:39 +0000 Received: from farnswood.snap.net.nz (p221-tnt1.snap.net.nz [202.124.110.221]) by viper.snap.net.nz (Postfix) with ESMTP id E2C855F5AC9; Sun, 31 Jul 2005 10:47:35 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 98D7562A99; Sat, 30 Jul 2005 23:16:32 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17131.64575.780190.163527@farnswood.snap.net.nz> Date: Sat, 30 Jul 2005 22:47:00 -0000 To: Bob Rossi Cc: gdb-patches@sources.redhat.com Subject: Re: MI testsuite to use PTY for inferior In-Reply-To: <20050730173855.GA21401@white> References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> X-SW-Source: 2005-07/txt/msg00231.txt.bz2 Bob Rossi writes: > > This seems to try to open a new pty even if inferior_pty is false. Shouldn't > > the condition, here and elsewhere, be: > > > > if { $inferior_pty } { > > I think this could be a style issue, but I'm not sure. I only create the > inferior_pty variable if mi_gdb_start's INFERIOR_PTY is true. Then I > check in later calls to see if the variable inferior_pty exists via > 'info exists inferior_pty'. Perhaps I've not understood the context but what if somenone uses: if {[mi_gdb_start false]} { as a condition for a test? Nick