From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31926 invoked by alias); 27 Jul 2005 11:46:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31915 invoked by uid 22791); 27 Jul 2005 11:46:53 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 27 Jul 2005 11:46:53 +0000 Received: from farnswood.snap.net.nz (p133-tnt2.snap.net.nz [202.124.108.133]) by viper.snap.net.nz (Postfix) with ESMTP id 5595B5F5DCE; Wed, 27 Jul 2005 23:46:49 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 453F562A99; Wed, 27 Jul 2005 12:47:50 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17127.29797.456624.592127@farnswood.snap.net.nz> Date: Wed, 27 Jul 2005 11:46:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: tests for MI commands In-Reply-To: <20050727035503.GA30670@nevyn.them.org> References: <17117.55351.716393.763492@farnswood.snap.net.nz> <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00207.txt.bz2 Daniel Jacobowitz writes: > ...But it > looks like these failures are related to your change: > > +FAIL: gdb.mi/mi-var-child.exp: listing of children, simple types: names, type and values, complex types: names and types I don't get this failure (this is one file I did test!). > +FAIL: gdb.mi/mi-var-display.exp: get children local variable weird I think this test should be removed as there was an identical test in mi-var-child.exp (which I have now modified for 12 elements). > +FAIL: gdb.mi/mi2-stack.exp: stack locals listing 0 > +FAIL: gdb.mi/mi2-stack.exp: next in callee4 (timeout) > +FAIL: gdb.mi/mi2-stack.exp: stack locals listing 1 > +FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations > +FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations.long_array > +FAIL: gdb.mi/mi2-var-child.exp: get number of children of struct_declarations.long_array > +FAIL: gdb.mi/mi2-var-child.exp: get children of weird > +FAIL: gdb.mi/mi2-var-child.exp: get children of weird.long_array > +FAIL: gdb.mi/mi2-var-child.exp: get number of children of weird.long_array > +FAIL: gdb.mi/mi2-var-child.exp: delete var weird > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_a0_0 (stopped at wrong place) > +FAIL: gdb.mi/mi2-var-child.exp: delete var struct_declarations > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 1 (stopped at wrong place) > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 2 (stopped at wrong place) > +ERROR: Got interactive prompt. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->char_ptr (and 0.char_ptr) changed > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 3 (timeout) > +ERROR: Got interactive prompt. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->char_ptr (and 1.char_ptr) changed > +ERROR: Couldn't send -var-update * to GDB. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->char_ptr (and 2.char_ptr) chang ed > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 5 (timeout) > +ERROR: Couldn't send -var-update * to GDB. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->long_ptr (and 0.long_ptr) changed > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 6 (timeout) > +ERROR: Couldn't send -var-update * to GDB. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->long_ptr (and 1.long_ptr) changed > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 7 (timeout) > +ERROR: Couldn't send -var-update * to GDB. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->long_ptr (and 2.long_ptr) changed > +FAIL: gdb.mi/mi2-var-display.exp: get children local variable weird > > Please fix them - I think the easiest thing to do is to revert the > changes to the affected source files and switch those two modified > tests to using new source files. Given the scarce resources for this unpaid work I ask you again to consider removing the mi2-*.exp files and just test the current version of MI. The reality is that they serve no useful purpose (mi-*.exp tests would still pass if GDB was invoked with "-i=mi2") and they require effort that could be better spent on other things. > As a side note, the trick to getting the CVS logs to come out right is > not just to use the same commit message for every file, but to commit > them together in a single invocation of cvs. See the mailing list > archives for gdb-cvs to see the difference. I can see the difference in the archive but not the CVS logs. I commit using VC in Emacs which seems to require separate commits but I'll work out how to do this as one commit for next time. Nick