From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7981 invoked by alias); 15 Jul 2005 03:59:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7973 invoked by uid 22791); 15 Jul 2005 03:59:33 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 15 Jul 2005 03:59:33 +0000 Received: from farnswood.snap.net.nz (p62-tnt1.snap.net.nz [202.124.110.62]) by viper.snap.net.nz (Postfix) with ESMTP id 471245C9DF6; Fri, 15 Jul 2005 15:59:29 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 2EB0962A99; Fri, 15 Jul 2005 04:58:45 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17111.13428.966975.183852@farnswood.snap.net.nz> Date: Fri, 15 Jul 2005 03:59:00 -0000 To: Daniel Jacobowitz Cc: Eli Zaretskii , Bob Rossi , gdb-patches@sources.redhat.com Subject: Re: [PATCH: gdb/mi + doco] -var-update In-Reply-To: <20050715014341.GA23331@nevyn.them.org> References: <20050502040526.GA10023@nevyn.them.org> <17013.54662.20554.239976@farnswood.snap.net.nz> <20050617034329.GH17013@nevyn.them.org> <20050617140410.GA24575@nevyn.them.org> <20050703195630.GM13811@nevyn.them.org> <20050704050151.GA8321@nevyn.them.org> <17099.44050.219050.156429@farnswood.snap.net.nz> <20050715014341.GA23331@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00128.txt.bz2 Daniel Jacobowitz writes: > For the future, I'd appreciate it if you didn't post partial patches > this way; I went back and dug up the right diffs, which isn't hard, but > is error-prone. But I can handle it :-) OK. > My version of TCL really did not like your testcase. Did you attach > the right patch? This one referenced var1 in the regexp but not in the > command, so it seems that it couldn't have passed. And it added some > weird trailing whitespace. Thats strange, I don't know how it passed. I must have got the initial output using var1 but earlier tests failed until I added extra backslashes etc. I'll take another look. > This patch includes the missing files, and I redid the varobj change in > a pedantically different way. Thanks for catching my goof there, by > the way. And caught a bad argc check on -var-list-children that I > think you picked up from me at some point. Your change is clearly more object oriented. I don't know why varobj.c is in the gdb directory: it's only really used by mi-cmd-var.c. How about moving it into the mi directory, or even merging it with mi-cmd-var.c to form one file? That way all the static functions currently in varobj.c will be automatically accessible to the functions currently in mi-cmd-var.c. > How's it look? If it looks good to you, I'll check it in, and then you > can commit the documentation and we can work out what happened to your > testcase. Yes, it looks good to me. Perhaps I can test it more fully once you've committed it. Now that the hectic release schedule of GDB has slowed down, I think this is a good way to work. I'm not sure that you will agree, though. > Also, this is for later, but I noticed some inconsistency in reviewing > the docs: > > -stack-list-locals > --no-values doesn't print types. > --simple-value prints the types for everything, even complex values. > --all-values doesn't print types. > > -var-list-children always prints types, regardless of the PRINT_VALUES > option given. > > -var-update never prints types, regardless of the PRINT_VALUES option. Previously -stack-list-locals and -var-update didn't print types while -var-list-children did. For -stack-list-locals, I added the type so that I could display that in the locals buffer instead of the value(s) for complex types. The user could then examine the values with variable objects if he wished. > Should some of those be cleaned up? At a guess, I'd make > -stack-list-locals --all-values print types, and -var-update > --all-values or --simple-values. Didn't think about it much though. I think the behaviour should be governed by use not consistency. I don't really have an opinion though as I will only use: -stack-list-locals --simple-values -var-list-children --all-values -var-update --all-values If "-var-update --all-values" prints types, I can easily arrange for Emacs to ignore it. Nick