From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19359 invoked by alias); 4 Jul 2005 03:07:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19346 invoked by uid 22791); 4 Jul 2005 03:07:45 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 04 Jul 2005 03:07:45 +0000 Received: from farnswood.snap.net.nz (p79-tnt1.snap.net.nz [202.124.110.79]) by viper.snap.net.nz (Postfix) with ESMTP id E353B5CD5C2; Mon, 4 Jul 2005 15:07:40 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id BB95E62A99; Mon, 4 Jul 2005 04:08:54 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17096.43077.948790.211753@farnswood.snap.net.nz> Date: Mon, 04 Jul 2005 03:07:00 -0000 To: Daniel Jacobowitz Cc: Eli Zaretskii , Bob Rossi , gdb-patches@sources.redhat.com Subject: Re: [PATCH: gdb/mi + doco] -var-update In-Reply-To: <20050703195630.GM13811@nevyn.them.org> References: <16929.8147.933720.246602@farnswood.snap.net.nz> <16955.41017.161288.832646@farnswood.snap.net.nz> <20050401024942.GA2179@white> <17013.35649.62745.226730@farnswood.snap.net.nz> <20050502040526.GA10023@nevyn.them.org> <17013.54662.20554.239976@farnswood.snap.net.nz> <20050617034329.GH17013@nevyn.them.org> <20050617140410.GA24575@nevyn.them.org> <20050703195630.GM13811@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00038.txt.bz2 Daniel Jacobowitz writes: ... > Nick, here's a patch based on yours which adds -var-list-children > --simple-values and -var-update --simple-values/--all-values. I like > it; I think --simple-values is useful (since for anything other than > simple values, an IDE is likely to want to print each member > individually...). > > I didn't revise the documentation because your last posted patch didn't > include the current manual diff. I also didn't write any testcases. > Both of these need to be done before the patch goes in. Tested on > i686-pc-linux-gnu, both the testsuite and by hand for -var-update. > > No incompatible changes, option consistency, and behavior consistency. > I don't think I can do any better than this :-) Nick, Eli, are you > both OK with this version of the code changes? Yes, this looks good. I have tested it with my current version of gdb-mi.el and it seems to work. I will try to dig out the relevant patch for the documentation and rework it, if Eli is also agreeable to this revision. ... > - if (argc != 1 && argc != 2) > + if (argc > 2) This gives: (gdb) -var-list-children &"Variable object not found\n" ^error,msg="Variable object not found" (gdb) instead of: (gdb) -var-list-children &"mi_cmd_var_list_children: Usage: NAME.\n" ^error,msg="mi_cmd_var_list_children: Usage: NAME." (gdb) I don't know if that's what you intended. Nick