From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40071-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 2992 invoked by alias); 20 Jun 2005 01:24:37 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 2973 invoked by uid 22791); 20 Jun 2005 01:24:33 -0000
Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 01:24:33 +0000
Received: from farnswood.snap.net.nz (p5-tnt2.snap.net.nz [202.124.108.5])
	by viper.snap.net.nz (Postfix) with ESMTP id 5A3CD54A754;
	Mon, 20 Jun 2005 13:24:30 +1200 (NZST)
Received: by farnswood.snap.net.nz (Postfix, from userid 501)
	id 7B20F62A99; Mon, 20 Jun 2005 02:25:29 +0100 (BST)
From: Nick Roberts <nickrob@snap.net.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17078.6920.672827.180846@farnswood.snap.net.nz>
Date: Mon, 20 Jun 2005 01:24:00 -0000
To: Daniel Jacobowitz <drow@false.org>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] -stack-info-frames
In-Reply-To: <20050620000041.GA25632@nevyn.them.org>
References: <17075.30993.384316.356236@farnswood.snap.net.nz>
	<20050618015756.GA30430@nevyn.them.org>
	<uhdfw10go.fsf@gnu.org>
	<17075.57612.684597.392526@farnswood.snap.net.nz>
	<20050618155742.GB3663@nevyn.them.org>
	<17076.42233.730605.834264@farnswood.snap.net.nz>
	<20050618232032.GA28368@nevyn.them.org>
	<17076.59646.873454.551250@farnswood.snap.net.nz>
	<20050619145612.GA8219@nevyn.them.org>
	<17077.61587.164352.664225@farnswood.snap.net.nz>
	<20050620000041.GA25632@nevyn.them.org>
X-SW-Source: 2005-06/txt/msg00304.txt.bz2

 > >  > > 1) mi_cmd_stack_info_frame uses print_frame_info instead of
 > >  > >    print_stack_frame.  This follows mi_cmd_stack_list_frames and means
 > >  > >    that the argument values aren't printed.
 ...

 > > Which change?
 > 
 > #1.  Why not print the arguments?  I guess your logic is that if you
 > want them, you can find them by a round trip through
 > -stack-list-frames, is that it?

Well, through -stack-list-arguments (mi_cmd_stack_list_frames doesn't print
arguments: I've used the same call to print_frame_info in -stack-info-frame).
Also print_stack_frame calls eventually calls print_frame_info after a call to
catch_errors, so it seemed more efficient.

Nick