From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3275 invoked by alias); 20 Jun 2005 03:28:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3237 invoked by uid 22791); 20 Jun 2005 03:28:29 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 03:28:29 +0000 Received: from farnswood.snap.net.nz (p66-tnt2.snap.net.nz [202.124.108.66]) by viper.snap.net.nz (Postfix) with ESMTP id B81FC562956; Mon, 20 Jun 2005 14:28:52 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 2F07562A99; Mon, 20 Jun 2005 03:27:40 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17078.10651.458286.19457@farnswood.snap.net.nz> Date: Mon, 20 Jun 2005 03:28:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] mi-stack.exp In-Reply-To: <20050620013409.GB30942@nevyn.them.org> References: <17078.5246.665299.878084@farnswood.snap.net.nz> <20050620013409.GB30942@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00309.txt.bz2 > > * gdb.mi/mi-stack.exp (test_stack_locals_listing): > > Remove test for -stack-select-frame without arguments. > > (test_stack_frame_listing): > > Add test for newly implemented command -stack-info-frame. > > OK. Please wrap it this way: > > * gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for > -stack-select-frame without arguments. > (test_stack_frame_listing): Add test for newly implemented command > -stack-info-frame. OK. (I find the log message easier to read when it fits on one line) > > *** /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp.~1.15.~ 2005-05-18 > > 20:18:15.000000000 +1200 --- > > /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp 2005-06-19 > > 18:49:18.000000000 +1200 > > Could you see about submitting relative diffs? It doesn't really > matter what they're relative _to_ - common is -p0 or -p1 to the top > directory whose ChangeLog you're touching. But this is a bit awkward > to apply. Like below? (This is with vc-diff in Emacs) > As an aside, if you don't mind, please check in patches all at once. > When you check in each file separately with its own log message, > automated tools can't reconstruct the entire change. You mean, for example, the log message: * mi/mi-cmd-stack.c (mi_cmd_stack_info_frame): New function. * mi/mi-cmds.c (mi_cmds): Replace entry for -stack-info-frame. Make it use mi_cmd_stack_info_frame * mi/mi-cmds.h (mi_cmd_stack_info_frame): New declaration. should appear in the individual CVS log for each of the files mi/mi-cmd-stack.c, mi/mi-cmds.c and mi/mi-cmds.h? I thought that the ChangeLog was there for that purpose. Nick 2005-06-20 Nick Roberts * gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for -stack-select-frame without arguments. (test_stack_frame_listing): Add test for newly implemented command -stack-info-frame. *** mi-stack.exp 18 May 2005 20:18:15 +1200 1.15 --- mi-stack.exp 19 Jun 2005 18:49:18 +1200 *************** *** 55,60 **** --- 55,61 ---- # -stack-list-frames # -stack-list-frames 1 1 # -stack-list-frames 1 3 + # -stack-info-frame mi_gdb_test "231-stack-list-frames" \ "231\\^done,stack=\\\[frame=\{level=\"0\",addr=\"$hex\",func=\"callee4\",file=\".*basics.c\",fullname=\"${fullname_syntax}${srcfile}\",line=\"$line_callee4_body\"\},frame=\{level=\"1\",addr=\"$hex\",func=\"callee3\",.*\},frame=\{level=\"2\",addr=\"$hex\",func=\"callee2\",.*\},frame=\{level=\"3\",addr=\"$hex\",func=\"callee1\",.*\},frame=\{level=\"4\",addr=\"$hex\",func=\"main\",.*\}\\\]" \ *************** *** 69,74 **** --- 70,79 ---- mi_gdb_test "234-stack-list-frames 1" \ "234\\^error,msg=\"mi_cmd_stack_list_frames: Usage.*FRAME_LOW FRAME_HIGH.*\"" \ "stack frame listing wrong" + + mi_gdb_test "235-stack-info-frame" \ + "235\\^done,frame=\{level=\"0\",addr=\"$hex\",func=\"callee4\",file=\".*basics.c\",fullname=\"${fullname_syntax}${srcfile}\",line=\"$line_callee4_body\"\}" \ + "selected frame listing" } proc test_stack_args_listing {} { *************** *** 187,202 **** "232\\^done,locals=\\\[\\\]" \ "stack locals listing for new frame" - # this should be a no-op - - mi_gdb_test "232-stack-select-frame" \ - "232\\^done" \ - "stack select same frame" - mi_gdb_test "232-stack-list-locals 1" \ "232\\^done,locals=\\\[\\\]" \ "stack locals for same frame (level 1)" - } mi_runto callee4