From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31620 invoked by alias); 16 Jun 2005 22:58:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31590 invoked by uid 22791); 16 Jun 2005 22:58:48 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 16 Jun 2005 22:58:48 +0000 Received: from farnswood.snap.net.nz (p147-tnt2.snap.net.nz [202.124.108.147]) by viper.snap.net.nz (Postfix) with ESMTP id CA5A754E7EE; Fri, 17 Jun 2005 10:58:44 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id DEB6A62A99; Thu, 16 Jun 2005 23:50:30 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17074.566.194312.713028@farnswood.snap.net.nz> Date: Thu, 16 Jun 2005 22:58:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-select-frame In-Reply-To: <20050616132120.GA5277@nevyn.them.org> References: <17072.62436.183299.55978@farnswood.snap.net.nz> <20050616044209.GA5907@nevyn.them.org> <17073.5179.249482.402135@farnswood.snap.net.nz> <20050616132120.GA5277@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00226.txt.bz2 > My concern was that this added a new item to a response which previous > had zero. Why do you think people couldn't use it as is? Seems > perfectly usable to me; if you know the level of a frame you want to > select, then you probably already have the result of a backtrace which > includes a printout of the stack frame, so you probably don't need > another! -stack-select-frame without an argument currently works like the CLI command "frame" without the output. All "frame" does is output the current frame, so without output its a bit of a no-op. -stack-select-frame with an argument just works like up, down or more precisely "frame FRAMENUM". So ,these CLI commands could be used directly in the short term, and via "-interpreter-exec console" in the longer term, if the frontend is not interested in the output. > Could you explain why you think we need output here? If you have a backtrace then, no, you don't need the output and the frontend can ignore it. However, I presume "-stack-select-frame" runs more quickly than "-stack-list-frames" so, if you don't need a backtrace, its probably best not to require one. > > > > ! ^done,frame=@{level="2",addr="0x000107a4",func="foo", > > > > ! file="recursive2.c",fullname="/home/foo/bar/devo/myproject/recursive2.c",line=line="14"@}, > > > > > > The double line= is a typo, right? > > > > I've just copied it from another part of the manual. In the node > > "GDB/MI Command Description Format" it says: > > > > Manual> Note the the line breaks shown in the examples are here only for > > Manual> readability. They don't appear in the real output. > > No, the bit that says "line=line="14"". Doh! Nick