From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1761 invoked by alias); 16 Jun 2005 23:04:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1023 invoked by uid 22791); 16 Jun 2005 23:04:02 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 16 Jun 2005 23:04:02 +0000 Received: from farnswood.snap.net.nz (p172-tnt2.snap.net.nz [202.124.108.172]) by viper.snap.net.nz (Postfix) with ESMTP id DF1A153AE11; Fri, 17 Jun 2005 11:03:59 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id EFB2562A99; Fri, 17 Jun 2005 00:05:04 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17074.1440.40908.588287@farnswood.snap.net.nz> Date: Thu, 16 Jun 2005 23:04:00 -0000 To: Jason Molenda Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-select-frame In-Reply-To: <50B12BF2-9C7D-43ED-AF21-D1EA42AC7115@apple.com> References: <17072.62436.183299.55978@farnswood.snap.net.nz> <50B12BF2-9C7D-43ED-AF21-D1EA42AC7115@apple.com> X-SW-Source: 2005-06/txt/msg00227.txt.bz2 > I don't care, really, but isn't necessary in our experience at > Apple. The first thing a GUI has to do when execution has stopped is > get the current stack. It shows the stack to the developer, and then > the developer decides that stack frame 2 is of interest to her, so > she clicks there and the GUI sends stack-select-frame. The GUI > already has the stack-list-frames output from when it stopped -- it > knows very well what's at frame 2. I thought it would save some time if the user doesn't need to see the whole stack. > If the GUI has short term memory problems, stack-list-frames is > always at its disposal. > > > * mi/mi-cmd-stack.c (mi_cmd_stack_select_frame): Don't test for > > stack. Print frame details. > > > enum mi_cmd_result > > mi_cmd_stack_select_frame (char *command, char **argv, int argc) > > { > > - if (!target_has_stack) > > - error (_("mi_cmd_stack_select_frame: No stack.")); > > - Because now GDB will report it as follows: -stack-select-frame &"No stack.\n" ^error,msg="No stack." (gdb) Nick