From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20939 invoked by alias); 16 Jun 2005 06:41:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20902 invoked by uid 22791); 16 Jun 2005 06:41:27 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 16 Jun 2005 06:41:27 +0000 Received: from farnswood.snap.net.nz (p6-tnt1.snap.net.nz [202.124.110.6]) by viper.snap.net.nz (Postfix) with ESMTP id F2FF7556002; Thu, 16 Jun 2005 18:41:23 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id E669762A99; Thu, 16 Jun 2005 06:55:07 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17073.5179.249482.402135@farnswood.snap.net.nz> Date: Thu, 16 Jun 2005 06:41:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-select-frame In-Reply-To: <20050616044209.GA5907@nevyn.them.org> References: <17072.62436.183299.55978@farnswood.snap.net.nz> <20050616044209.GA5907@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00217.txt.bz2 > - You're changing the behavior of a command; do people use this > command? Are you confident that they will handle the new output > gracefully? I'm not aware of anyone using this command - I don't see how they currently could really. I think its less likely to break existing behaviour than this change: 2005-05-17 Daniel Jacobowitz Dennis Brueni * stack.c (print_frame): In MI mode, output a fullname attribute with the stack frame. which must change the output for every frontend using MI. I don't see how MI can evolve without changing its behaviour. If it is significantly different presumably a new level can be added as before. > - Please, let's not add new MI features without matching testcases. I'll be happy to add testcases if there is a likelihood that my patch will be approved. > > ! ^done,frame=@{level="2",addr="0x000107a4",func="foo", > > ! file="recursive2.c",fullname="/home/foo/bar/devo/myproject/recursive2.c",line=line="14"@}, > > The double line= is a typo, right? I've just copied it from another part of the manual. In the node "GDB/MI Command Description Format" it says: Manual> Note the the line breaks shown in the examples are here only for Manual> readability. They don't appear in the real output. Nick