From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19386 invoked by alias); 13 Jun 2005 22:38:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19360 invoked by uid 22791); 13 Jun 2005 22:38:23 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 13 Jun 2005 22:38:23 +0000 Received: from farnswood.snap.net.nz (p160-tnt1.snap.net.nz [202.124.110.160]) by viper.snap.net.nz (Postfix) with ESMTP id 44D2C543A46; Tue, 14 Jun 2005 10:36:27 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id EAF1562A99; Mon, 13 Jun 2005 23:38:13 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17070.2773.135064.388886@farnswood.snap.net.nz> Date: Mon, 13 Jun 2005 22:38:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -data-list-changed-registers (Take 2) In-Reply-To: <20050613134759.GA7102@nevyn.them.org> References: <17053.38913.487990.775198@farnswood.snap.net.nz> <20050603191326.GA538@nevyn.them.org> <17056.56149.181259.513462@farnswood.snap.net.nz> <20050603223652.GA8203@nevyn.them.org> <17057.37727.725621.254956@farnswood.snap.net.nz> <17060.46539.131335.71422@farnswood.snap.net.nz> <17066.35303.833870.612064@farnswood.snap.net.nz> <20050613024022.GB9288@nevyn.them.org> <17069.4116.293354.462840@farnswood.snap.net.nz> <20050613134759.GA7102@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00172.txt.bz2 > > From mi_cmd_data_list_register_values, I removed: > > > > if (!target_has_registers) > > { > > mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers."); > > return MI_CMD_ERROR; > > } > > > > Why do you think it should stay? > > Cuz it was late and I wasn't paying a great deal of attention to your > patch, once I figured out the mi_out_rewind problem. In the interest > of uniformity, let's remove it. Could you (test and) commit the > obvious patch? Committed. I get many failures on the testsuite, I'll try to move to a newer PC/kernel. mi-regs.exp seems OK though. I would like to commit my changes to -var-update (2005-05-02) sometime. I have also removed a large number of annotations from my working copy. Andrew started this process, it would be nice if he can be involved but maybe thats not possible. There are a lot of changes to the following files: gdb/ada-valprint.c gdb/annotate.c gdb/annotate.h gdb/blockframe.c gdb/breakpoint.c gdb/cp-valprint.c gdb/event-top.c gdb/frame.c gdb/infrun.c gdb/interps.c gdb/jv-valprint.c gdb/p-valprint.c gdb/printcmd.c gdb/stack.c gdb/utils.c gdb/valprint.c Is anyone interested? It would be good to do this now as a release doesn't seem to be imminent. Nick 2005-06-14 Nick Roberts * mi/mi-main.c (mi_cmd_data_list_register_values): Remove test for registers now that mi_execute_command rewinds after an error. *** /home/nick/src/gdb/mi/mi-main.c.~1.79~ 2005-06-14 10:37:18.000000000 +1200 --- /home/nick/src/gdb/mi/mi-main.c 2005-06-14 09:18:08.000000000 +1200 *************** *** 433,444 **** format = (int) argv[0][0]; - if (!target_has_registers) - { - mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers."); - return MI_CMD_ERROR; - } - list_cleanup = make_cleanup_ui_out_list_begin_end (uiout, "register-values"); if (argc == 1) /* No args, beside the format: do all the regs */ --- 433,438 ----