From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5353 invoked by alias); 6 Jun 2005 20:44:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5326 invoked by uid 22791); 6 Jun 2005 20:44:21 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 06 Jun 2005 20:44:21 +0000 Received: from farnswood.snap.net.nz (p167-tnt1.snap.net.nz [202.124.110.167]) by viper.snap.net.nz (Postfix) with ESMTP id E5DD3538683; Tue, 7 Jun 2005 08:44:16 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 6055762A99; Mon, 6 Jun 2005 21:44:59 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17060.46539.131335.71422@farnswood.snap.net.nz> Date: Mon, 06 Jun 2005 20:44:00 -0000 To: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [PATCH] -data-list-changed-registers In-Reply-To: <17057.37727.725621.254956@farnswood.snap.net.nz> References: <17053.38913.487990.775198@farnswood.snap.net.nz> <20050603191326.GA538@nevyn.them.org> <17056.56149.181259.513462@farnswood.snap.net.nz> <20050603223652.GA8203@nevyn.them.org> <17057.37727.725621.254956@farnswood.snap.net.nz> X-SW-Source: 2005-06/txt/msg00046.txt.bz2 Nick Roberts writes: > > I think the changes are right in this case, though. Could you take a > > look at those two functions (the change to make is obvious) and see if > > that fixes your problem? > > If you mean the changes below, then these seem fine and give: Actually this isn't quite right: (gdb) -break-insert main ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0x080484d9",func="main",file="myprog.c",line="55",times="0"} (gdb) -data-list-changed-registers &"No registers.\n" ^error,msg="No registers." (gdb) -exec-run ^running (gdb) *stopped,changed-registers=[],reason="breakpoint-hit",bkptno="1",thread-id="0",frame={addr="0x080484d9",func="main",args=[{name="argc",value="1"},{name="argv",value="0xbffff794"}],file="myprog.c",fullname="/home/nick/myprog.c",line="55"} (gdb) -data-list-changed-registers ^done,changed-registers=["1","3","4","5","6","7","8","9","10","11","12","13","24","26","40","41"] (gdb) I think the changed-registers=[] after *stopped occurs because an exception is raised in register_changed_p in the _first_ call to mi_cmd_data_list_changed_registers and control doesn't return to to call do_cleanups (cleanup). Nick