From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10564 invoked by alias); 3 Jun 2005 22:35:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10532 invoked by uid 22791); 3 Jun 2005 22:35:20 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 03 Jun 2005 22:35:20 +0000 Received: from farnswood.snap.net.nz (p50-tnt2.snap.net.nz [202.124.108.50]) by viper.snap.net.nz (Postfix) with ESMTP id C71235377DF; Sat, 4 Jun 2005 10:35:16 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id D542A62A9A; Fri, 3 Jun 2005 23:36:05 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17056.56149.181259.513462@farnswood.snap.net.nz> Date: Fri, 03 Jun 2005 22:35:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -data-list-changed-registers In-Reply-To: <20050603191326.GA538@nevyn.them.org> References: <17053.38913.487990.775198@farnswood.snap.net.nz> <20050603191326.GA538@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00035.txt.bz2 Daniel Jacobowitz writes: > On Wed, Jun 01, 2005 at 11:12:01PM +1200, Nick Roberts wrote: > > > > Currently the GDB/MI command -data-list-changed-registers gives an internal > > error if there is no stack i.e when there is no inferior process: > > This has come up before; the right solution is elsewhere. I believe > that updating register_changed_p and get_register to use > get_selected_frame() will work. > > I have a big patch for this sort of thing lying around, but the problem > is that many of the references to deprecated_selected_frame should > really by fixed by adding a frame parameter to the function, so that > they can be used on non-selected frames. They need to be looked over > one by one and I haven't gotten round to it yet. Could this patch be applied as an interim measure? Currently any front end that uses -data-list-changed-registers without a stack crashes. Nick