From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10572 invoked by alias); 3 Jun 2005 22:35:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10539 invoked by uid 22791); 3 Jun 2005 22:35:20 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 03 Jun 2005 22:35:20 +0000 Received: from farnswood.snap.net.nz (p50-tnt2.snap.net.nz [202.124.108.50]) by viper.snap.net.nz (Postfix) with ESMTP id 00457537530; Sat, 4 Jun 2005 10:35:16 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id EB4C262A99; Fri, 3 Jun 2005 23:33:59 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17056.56022.36723.292491@farnswood.snap.net.nz> Date: Fri, 03 Jun 2005 22:35:00 -0000 To: Daniel Jacobowitz Cc: Bob Rossi , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Hooks still needed for annotations In-Reply-To: <20050603190856.GB32722@nevyn.them.org> References: <17053.24737.153388.915345@farnswood.snap.net.nz> <20050601113004.GC15414@white> <17054.10607.109160.333076@farnswood.snap.net.nz> <20050603190856.GB32722@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00034.txt.bz2 > > I don't currently use breakpoints-invalid but I might wish to at one > > stage. I want to ensure that annotations aren't quietly removed by > > dismantling them bit by bit. > > If that's what you want to accomplish, your patch should include test > cases for these annotations. Otherwise they're likely to be "cleaned > up". Also, please do not comment out code; if it's wrong, it should be > deleted. I left the comment there to try to prevent them being removed again. If I remove then I would also like to remove the deprecated prefix for the two hooks. In the past Andrew (Sat, 01 Mar 2003 21:37:33 -0500) has discriminated between two types of annotations: > - markups, as in the above marking up of the breakpoint out > - events, as in things like `*stopped' The general idea was that the former would go while the latter would stay. Clearly breakpoints-invalid belongs to the latter. The point about keeping them is that they can be used for event notification in MI (Tue, 8 Feb 2005 10:14:31 +1300). Th manual says: > `ASYNC-CLASS ==>' > `"stopped" | OTHERS' (where OTHERS will be added depending on the > needs--this is still in development). I do not have enough knowldege of GDB to work out when breakpoint information changes in the code. So I would like to use the calls to breakpoints_changed (breakpoints-invalid) to do this and generate MI output: =breakpoint-changed,BreakpointTable={nr_rows... Nick