From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9530 invoked by alias); 8 Dec 2016 20:15:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9137 invoked by uid 89); 8 Dec 2016 20:15:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=MIPS-specific, MIPSspecific, CORE, prpsinfo X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Dec 2016 20:15:31 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cF56E-0007O0-AM from Luis_Gustavo@mentor.com ; Thu, 08 Dec 2016 12:15:26 -0800 Received: from [172.30.6.208] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 8 Dec 2016 12:15:23 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 3/3] Add native target for FreeBSD/mips. References: <20161206210015.40422-1-jhb@FreeBSD.org> <20161206210015.40422-4-jhb@FreeBSD.org> <472bfba9-72b3-4432-95d9-e4b523667d1f@codesourcery.com> <1801089.38MhW5CcGm@ralph.baldwin.cx> To: John Baldwin CC: , From: Luis Machado Message-ID: <16a736be-5a63-e52a-1e84-614ab097e6a6@codesourcery.com> Date: Thu, 08 Dec 2016 20:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1801089.38MhW5CcGm@ralph.baldwin.cx> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00219.txt.bz2 On 12/08/2016 02:03 PM, John Baldwin wrote: > On Thursday, December 08, 2016 12:53:06 PM Luis Machado wrote: >> On 12/06/2016 03:00 PM, John Baldwin wrote: >>> This supports the o32 and n64 ABIs. >>> >>> gdb/ChangeLog: >>> >>> * Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c. >>> * config/mips/fbsd.mh: New file. >>> * configure.host: Add mips*-*-freebsd*. >>> * mips-fbsd-nat.c: New file. >>> --- >>> gdb/ChangeLog | 7 +++ >>> gdb/Makefile.in | 1 + >>> gdb/config/mips/fbsd.mh | 3 ++ >>> gdb/configure.host | 1 + >>> gdb/mips-fbsd-nat.c | 141 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> 5 files changed, 153 insertions(+) >>> create mode 100644 gdb/config/mips/fbsd.mh >>> create mode 100644 gdb/mips-fbsd-nat.c >>> >>> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >>> index 890702e..fc43f81 100644 >>> --- a/gdb/ChangeLog >>> +++ b/gdb/ChangeLog >>> @@ -1,5 +1,12 @@ >>> 2016-12-06 John Baldwin >>> >>> + * Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c. >>> + * config/mips/fbsd.mh: New file. >>> + * configure.host: Add mips*-*-freebsd*. >>> + * mips-fbsd-nat.c: New file. >>> + >>> +2016-12-06 John Baldwin >>> + >>> * Makefile.in (ALL_TARGET_OBS): Add mips-fbsd-tdep.o. >>> (ALLDEPFILES): Add mips-fbsd-tdep.c. >>> * configure.tgt: Add mips*-*-freebsd*. >>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in >>> index e34fa4a..dee9d73 100644 >>> --- a/gdb/Makefile.in >>> +++ b/gdb/Makefile.in >>> @@ -2542,6 +2542,7 @@ ALLDEPFILES = \ >>> microblaze-linux-tdep.c \ >>> microblaze-tdep.c \ >>> mingw-hdep.c \ >>> + mips-fbsd-nat.c \ >>> mips-fbsd-tdep.c \ >>> mips-linux-nat.c \ >>> mips-linux-tdep.c \ >>> diff --git a/gdb/config/mips/fbsd.mh b/gdb/config/mips/fbsd.mh >>> new file mode 100644 >>> index 0000000..f433347 >>> --- /dev/null >>> +++ b/gdb/config/mips/fbsd.mh >>> @@ -0,0 +1,3 @@ >>> +# Host: FreeBSD/mips >>> +NATDEPFILES= fork-child.o inf-ptrace.o fbsd-nat.o mips-fbsd-nat.o >>> +HAVE_NATIVE_GCORE_HOST = 1 >> >> I suppose you tried the gcore command for native GDB on FreeBSD/MIPS and >> it worked fine? > > It mostly does. I can read the core fine using native GDB on MIPS, but > an x86 GDB doesn't parse the generated core correctly (though it does > parse a native core from the kernel correctly). The issue here though > isn't really a MIPS-specific one. Right now the FreeBSD target-dependent > code uses code from binutils to write out the prpsinfo and prstatus notes > and those write Linux-style "CORE" notes. I have a todo to fix gcore in > gdb to write out "FreeBSD" process and thread status notes instead which > will fix this (along with a separate, but somewhat similar issue with > gdb's gcore on FreeBSD/powerpc). > Ok. I'm just making sure the feature is mostly usable before we enable it (gcore) here. It sounds like it is.