From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8514 invoked by alias); 27 Apr 2016 18:36:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8494 invoked by uid 89); 27 Apr 2016 18:36:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:666, eye, him X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 18:36:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 311AB4F5; Wed, 27 Apr 2016 18:36:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RIafxw009472; Wed, 27 Apr 2016 14:36:41 -0400 Subject: Re: [PATCH 6/8] Add support for the Rust language To: Tom Tromey References: <1461725371-17620-1-git-send-email-tom@tromey.com> <1461725371-17620-7-git-send-email-tom@tromey.com> <5720A5E4.2020603@redhat.com> <87y47yc3ge.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1694de56-483b-df19-38e5-c1191e10ff84@redhat.com> Date: Wed, 27 Apr 2016 18:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87y47yc3ge.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00606.txt.bz2 On 04/27/2016 07:27 PM, Tom Tromey wrote: >>> +static struct disr_info >>> +rust_get_disr_info (struct type *type, const gdb_byte *valaddr, > > Pedro> Did you mean to name these discr_info and rust_get_discr_info ? > Pedro> I mean, the missing 'c'. > > Manish wrote this part -- but not to blame him, this actually mirrors > what is done in the Rust compiler. I don't know why that abbreviation > was chosen by Rust. However, it is visible in the debuginfo, as enum > discriminants can be named "RUST$ENUM$DISR". Alright. I'm fine with whatever. It just looked odd to the rust-untrained eye. Thanks, Pedro Alves