From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KY/EBkZn8mlHNwQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 16:17:10 -0400 Received: by simark.ca (Postfix, from userid 112) id 1637C1E0CA; Wed, 29 Apr 2026 16:17:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7BB271E0B1 for ; Wed, 29 Apr 2026 16:17:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2C9D94BBCD9B for ; Wed, 29 Apr 2026 20:17:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C9D94BBCD9B Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id F30124BBCDB7 for ; Wed, 29 Apr 2026 20:16:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F30124BBCDB7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F30124BBCDB7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777493805; cv=none; b=fmnRB88hvxnGda/GQzcVqTWEfTsnlTWcdXCrnr95Szmk4AgK5U15y2kSy/m3gxjIdgsvtJLMq1/OIbtL/vRHH3ZMPfA4pF/MJyKcXvdCd+ki28Do2PSAb5RQL2WjiGIIDkf2a7CFC00n07YjjBs5Kpyfj6QHXscoavcu5xGm8kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777493805; c=relaxed/simple; bh=c/ReKoWf+jct1Uq1nnArrMDxesFDyElsebQpkdFgGC4=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=wGt3zha4ZV4EQQ7Z3Vr1Tq0F8O5kbVksnK35phi8mx+MT9ZkvFZwt2enWXwfAn5XQhRb3c4OnN4DKkhc0b2uShAGverlVoB3RGuuyOdHJJAx1M5/kHliQjHP4xUEw0q2bRqPIADf8YaZ6VxZtmUm858qGNZ5SUZ7HlmQVRWVk/Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F30124BBCDB7 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso1945295e9.3 for ; Wed, 29 Apr 2026 13:16:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777493804; x=1778098604; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1MK3hSRBcCnsbpaiRs3FZ/oLXJyxdsfeSS6UrYdaVdo=; b=PvAaLzqWRLSpE07ShobHXBVjRg8SHuqa9fkR1njBxNRp47F8DKZE7YFg4HFNMo+eTG 4PBI8SFqboVzsNmczWYLzXZL2aiYwY75kBoabYUlzhFmiK7M422v7pHN9OL4fYFqvhVq pm7Rw6sRlZBGRD61slduPWENiWGBeftRD6QnDbS+5kGjJtx2AWKIaRAdIOkz3+34t/Uq XPRoETHrskt3EzMnamVJ8YfI5CrzivSDsXtB7O9xWKDIK+RQy9xNuQpam+T0R84CS19q Jlb7CZFjIkE/FjdwJhbFoIYe+6xvEHahPMbiqQ5vA6nbZddU91P3PnOfXc9kkiuzt9Pn u2zg== X-Gm-Message-State: AOJu0YynKweI9eYjqnzoWj0XZjCeA3KpynLKL22v1XLvb9Bc+rNko173 xh62McNMn/qatnlZ8Nj1JyQDLUY3R81g7JLHNv7EbjMyGnQQeTXdS3KSErPMfw== X-Gm-Gg: AeBDieseTgUNNIbLBmzHczSwsHD9+hdzspb3jZCEURD7DdG/wTPGZM1NCbDMBeiRf7z 6L2s+73dFEMSOLBlTv4e7MzVTax29ceqcQY316q1LJVMU3rIHKSSeEWSF1/i3NwIFUQLN6M4eCJ HUV6zmX2L3bH8EXPA70OACI9j1eZrByhLHyhBpTMcMHTvzD3+ym8tLT8OQDXSdjh3SHXj7fxWsu N2x7nQFYiITyDfxpgzUyGLJpwD9mtpbGcUwpoLmrpCVG8pgCr6tqiPGEEfKFvIBceAaXWLKmVmL oyP7CUWKn0pLnHu1doQzZyqAcxC38VgUBSNDBPBM21FP5gRbPSgpa8I32wRcYk3xm5rw7d5BN1c /S/KoN/ISaNmabBMAgZS4d1Y3Ufpl+22dhnY2uxLqI4wTLu68DP5fBVpae/pEaI+KdNb9umSjgL yBdMP3x9YdDxkmITEC3pVuCyqfdXBW9GIk7tTtvKPYM/RemM6x1BileqAAMiujG0qD+kKU+xIJd Hv7qQD8NcVW X-Received: by 2002:a05:600d:1b:b0:48a:592c:e642 with SMTP id 5b1f17b1804b1-48a844458d8mr1257325e9.18.1777493803828; Wed, 29 Apr 2026 13:16:43 -0700 (PDT) Received: from ?IPV6:2001:8a0:facb:a800:f22f:591f:e700:e91? ([2001:8a0:facb:a800:f22f:591f:e700:e91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7b91285esm27236595e9.5.2026.04.29.13.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 13:16:43 -0700 (PDT) Message-ID: <168a44ce-a9b9-4d70-9ca2-f67e408920b5@palves.net> Date: Wed, 29 Apr 2026 21:16:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 37/47] Windows GDB: make windows_thread_info be private thread_info data To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-38-pedro@palves.net> <87v7pkecmf.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <87v7pkecmf.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, I found I had never replied to this one. On 2025-05-28 20:52, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> When that is supported, and the core wants to be notified of thread > Pedro> exit events, the target backend does not delete the thread for which > Pedro> the event is being reported. Instead, infrun takes care of that. > > I did not know about this detail ... is this documented somewhere? In v3, I've added a note, like so: --- c/gdb/target/waitstatus.h +++ w/gdb/target/waitstatus.h @@ -105,7 +105,9 @@ enum target_waitkind /* The thread was created. */ TARGET_WAITKIND_THREAD_CREATED, - /* The thread has exited. The exit status is in value.integer. */ + /* The thread has exited. The exit status is in value.integer. The + thread should still exist in the thread list when infrun receives + this event. */ TARGET_WAITKIND_THREAD_EXITED, > Pedro> +/* Get the windows_thread_info object associated with THR. */ > Pedro> + > Pedro> +static windows_thread_info * > Pedro> +as_windows_thread_info (thread_info *thr) > Pedro> +{ > Pedro> + /* Cast to windows_private_thread_info, which inherits from > Pedro> + private_thread_info, and is implicitly convertible to > Pedro> + windows_thread_info, the return type. */ > Pedro> + return static_cast (thr->priv.get ()); > > Should this use checked_static_cast instead? I did this change. Thanks, Pedro Alves