From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10552 invoked by alias); 6 Aug 2019 08:58:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10477 invoked by uid 89); 6 Aug 2019 08:58:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr130055.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.107.13.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 08:58:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MnfYJK758wonN3geIXqdkfOzANT00g7JKirQczqpjxY=; b=XZMAoqHWdAxZTK3P4ZDxq5yay+pK6hV2Qa2jDINVIkZKRkQl2HcXUCSuOFgd2Xj7HQn6ELN03gKElZn3mjRuu0nmY90KlBsCBjzq6+UKWvju+S2UIoj5Dyu1z/XwT7WZgQWZTQ4i2gvvMLg/oisSoNcBZKm5fk+xj1eI4R8OTcg= Received: from VI1PR08CA0256.eurprd08.prod.outlook.com (2603:10a6:803:dc::29) by AM6PR08MB4949.eurprd08.prod.outlook.com (2603:10a6:20b:e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Tue, 6 Aug 2019 08:58:46 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::203) by VI1PR08CA0256.outlook.office365.com (2603:10a6:803:dc::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2157.14 via Frontend Transport; Tue, 6 Aug 2019 08:58:46 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Tue, 6 Aug 2019 08:58:44 +0000 Received: ("Tessian outbound 220137ab7b0b:v26"); Tue, 06 Aug 2019 08:58:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4a2bb69f66ebb5d0 X-CR-MTA-TID: 64aa7808 Received: from a4a8a658ebe4.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70223624-E551-4E86-948E-CEA9FF312B00.1; Tue, 06 Aug 2019 08:58:39 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a4a8a658ebe4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Tue, 06 Aug 2019 08:58:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PDIqTQs+LocFk6MHPVtgIlKD0hAmoLHETZCOnRte/+PS/E/15/P616I/tpWqsLPe4IGYm08YVsAlv+ik4IFCciU2Uv+7V/krHpTsEwardKM2x9XeQvBMteAOVI5WPG4cchhtu3a7ptGYyqQ9XqjsPa50gWdNlh5w6MhDrfMz3g9y7SXvZ58Xxxr6fn+ACdm0zH6Z9S/7oDwhGTbjSp5+E60nRcP05T2r4Ru04ARBE0ci3KIb6JqnS3pOXDYd1nswC69OPC/HISADVZaLki3TiZjffFik2983BbPHDn4ceX63h6r81lj2z8zGXbUJCLAIIHiZZdyzKcOb2lg1id+9Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MnfYJK758wonN3geIXqdkfOzANT00g7JKirQczqpjxY=; b=mJq1eVGnZOy8ptonghV6mz/QZUue4JHSk5M8Jde5XB52iZKh4eKYWRx7Nvcz9R3XqER487msi3BbtmxEG1T9eZ6saMYtzPHSC5bDZahP2vYlOaIpEX/vtuZdNEgQQpH6s4Ii+DmtXAy5bPHt7a+VI6s3MG8KBTwaFOQHFwYNe/cu76ziE90T5dPmqQ6onOmSa7X4FNhC/knoezK5eEzy6a5bVJNxV1JIomuz5nSWe5Io/BocDUy+i6frwee3qNXH6X2h+xZNubCcx8y3PJg4Y/frNsbWbYivgEUFvcoXL4gE+uFSAyhDdoHNlMJmFdjClv7rP1rkMohCDjy8XmYEGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MnfYJK758wonN3geIXqdkfOzANT00g7JKirQczqpjxY=; b=XZMAoqHWdAxZTK3P4ZDxq5yay+pK6hV2Qa2jDINVIkZKRkQl2HcXUCSuOFgd2Xj7HQn6ELN03gKElZn3mjRuu0nmY90KlBsCBjzq6+UKWvju+S2UIoj5Dyu1z/XwT7WZgQWZTQ4i2gvvMLg/oisSoNcBZKm5fk+xj1eI4R8OTcg= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2598.eurprd08.prod.outlook.com (10.172.246.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.12; Tue, 6 Aug 2019 08:58:38 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::5ce5:cf42:42dd:eda1%6]) with mapi id 15.20.2136.018; Tue, 6 Aug 2019 08:58:37 +0000 From: Alan Hayward To: Tom Tromey CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue Date: Tue, 06 Aug 2019 08:58:00 -0000 Message-ID: <16866921-5116-49AE-A00E-9D738CE212BD@arm.com> References: <20190805124152.26127-1-alan.hayward@arm.com> <8736ifcxu8.fsf@tromey.com> In-Reply-To: <8736ifcxu8.fsf@tromey.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2598; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(189003)(199004)(54906003)(102836004)(316002)(99286004)(4326008)(53546011)(6506007)(7736002)(305945005)(81166006)(76176011)(81156014)(68736007)(26005)(186003)(8676002)(6116002)(3846002)(2906002)(53936002)(6246003)(476003)(66066001)(14444005)(256004)(446003)(11346002)(86362001)(486006)(6512007)(25786009)(5660300002)(229853002)(66446008)(6486002)(66476007)(71200400001)(6916009)(36756003)(2616005)(57306001)(66556008)(14454004)(66946007)(6436002)(64756008)(50226002)(76116006)(478600001)(71190400001)(8936002)(33656002)(91956017);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2598;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: hbDZzqaQYyX+kbd4AAB7IMRN7uLEMw1inek6Getx8rBhAkjY094ZhHeSGjktogSyAywrxzKLcc4iIGjnLSazr0+NWKZYonFCYOk2jZNwXe35LBXkc9MUst0x+8RsE9LPFnoPyIYU1BrA8IOs7ra4epzjgmN8CsrFlvsMRPH/23yFCzbHf0vd8hZG2jkDhukyot9EvIR9E9KDIKfCNGfc5IPqWWS7dqoCzAyWSb7ftPbMg+rdFdWcueR6sSK81GvVlstGIlzMES5FeoNmV+SsoCuf7D70obuiRCyKQ+1dYf81dZunMzxzfUSjd/hkloWztslZVitn3bnHWUbs3e5AXiJap5r0zN76wxwerv1l/TtODw6P0rx4y0e4C8WIlKiHX9Cczj6DBVhm5hYMU+iZaU1qUS4A74fqqFpOy9EfJUE= Content-Type: text/plain; charset="us-ascii" Content-ID: <827639E76478D74D8E6D57FD39A4676B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 79ad378a-cd4f-43cb-f7d8-08d71a4c455c X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00131.txt.bz2 > On 5 Aug 2019, at 18:43, Tom Tromey wrote: >=20 >>>>>> "Alan" =3D=3D Alan Hayward writes: >=20 > Alan> When saving registers to the stack at the start of a function, not = all state > Alan> needs to be saved. For example, only the first 64bits of float regi= sters need > Alan> saving. However, a program may choose to store extra state if it w= ishes, > Alan> there is nothing preventing it doing so. >=20 > Alan> The aarch64_analyze_prologue will error if it detects extra state b= eing > Alan> stored. Relex this restriction. >=20 > I don't know anything about AArch64, so I can't really comment on the > content of the patch, but I did happen to see a nit: >=20 > Alan> stack.store (pv_add_constant (regs[rn], > Alan> inst.operands[1].addr.offset.imm), > Alan> - is64 ? 8 : 4, regs[rt]); > Alan> + size, regs[rt]); >=20 > ...this addition looked mis-indented to me. Thanks. I probably missed that because the correct formatting looks horrible: stack.store (pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm), size, regs[rt]); Instead, I can update it to the following stack.store ( pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm), size, regs[rt]); >=20 > Tom