Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf2] Fix name of include psymtabs, avoid duplicates
Date: Mon, 29 Nov 2004 02:11:00 -0000	[thread overview]
Message-ID: <16810.33907.717155.200928@localhost.redhat.com> (raw)
In-Reply-To: <20041101194801.GI27334@gnat.com>


Joel Brobecker writes:

 > >         % gcc -gdwarf-2 -o main foo/main.c
 > > 
 > > When GDB scans the dwarf2 data to create the psymtabs, it scans
 > > the linetable for each CU and create "include psymtabs" for it.
 > > These psymtabs correspond to the files included from that CU
 > > (see call to dwarf2_build_include_psymtabs at the end of
 > > dwarf2_build_psymtabs_hard).
 > > 
 > > Unfortunately, a little omission in my part lead to a bug:
 > > 
 > >         (gdb) file main
 > >         (gdb) info sources
 > >         [...]
 > >         Source files for which symbols will be read in on demand:
 > >         [...], main.c, /home/brobecke/tmp/dup/foo/main.c, [...]

This seems easy to add to the testsuite. Just create a subdirectory in
gdb.dwarf2, and issue the above commands.
 

 > > 2004-10-16  Joel Brobecker  <brobecker@gnat.com>
 > > 
 > >         * dwarf2read.c (dwarf_decode_lines): Use the complete filename
 > >         when creating include psymtabs.
 > > 
 > > Tested on x86-linux, no regression.
 > > OK to apply?

Yes, after you add the test, which should fail before and pass after
your patch.


  reply	other threads:[~2004-11-29  2:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-17  1:02 Joel Brobecker
2004-11-01 19:48 ` Joel Brobecker
2004-11-29  2:11   ` Elena Zannoni [this message]
2004-12-01  3:31     ` Joel Brobecker
2005-03-09  6:12       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16810.33907.717155.200928@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox