From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18866 invoked by alias); 13 Aug 2007 22:27:17 -0000 Received: (qmail 18811 invoked by uid 22791); 13 Aug 2007 22:27:17 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 22:27:15 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l7DMRDiW011774; Mon, 13 Aug 2007 15:27:13 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Mon, 13 Aug 2007 15:27:13 -0700 (PDT) Message-ID: <16770.12.7.175.2.1187044033.squirrel@webmail.sonic.net> In-Reply-To: References: <5638.12.7.175.2.1186784359.squirrel@webmail.sonic.net> Date: Mon, 13 Aug 2007 22:27:00 -0000 Subject: Re: [PATCH] stack.c, memory leak (no-effect code?) From: msnyder@sonic.net To: "Jim Blandy" Cc: gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00262.txt.bz2 > > msnyder@sonic.net writes: >> This patch is to fix a memory leak, but while you're looking at it... >> does it seem to you that these two blocks have any effect? >> >> [Sorry if I posted this before, I've been searching for it...] > > You did post something very much like this, but I recall that the > blocks in question in the older post really didn't have any effect. > These at least set funname. > > I'm kind of surprised that they don't set funname to demangled when > it's non-NULL. OK, how about the patch itself?