From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21629 invoked by alias); 22 Oct 2004 03:31:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21622 invoked from network); 22 Oct 2004 03:31:50 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 22 Oct 2004 03:31:50 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id i9M3Vj4K016165 for ; Thu, 21 Oct 2004 23:31:50 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9M3Vdr25994 for ; Thu, 21 Oct 2004 23:31:39 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i9M3VdIi006440 for ; Thu, 21 Oct 2004 23:31:39 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 550861A467A; Thu, 21 Oct 2004 23:21:52 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16760.31952.258767.923659@localhost.redhat.com> Date: Fri, 22 Oct 2004 03:31:00 -0000 To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add parse_dwarf2_calling_convention functionality In-Reply-To: <20041008124826.GZ6702@cygbert.vinschen.de> References: <20041007095401.GN6702@cygbert.vinschen.de> <20041008124826.GZ6702@cygbert.vinschen.de> X-SW-Source: 2004-10/txt/msg00367.txt.bz2 Corinna Vinschen writes: > Hi, > > On Oct 7 11:54, Corinna Vinschen wrote: > > the second patch to prepare the calling convention stuff. It just adds > > the parse_dwarf2_calling_convention functionality to gdbarch. The > > below patch contains only the patch to gdbarch.sh (not the auto-generated > > gdbarch.[ch]) and the new default_parse_dwarf2_calling_convention function > > in arch-utils. > > Corrected patch below. It seems to be more useful to use the producer > field of the compilation unit instead of an artificial "gcc_compiled" > flag. The producer string is easily scanned and the information given > is more detailed than just a gcc_compiled flag. > > The below patch overrides the previous patch and also contains the > necessary change to dwarf2read.c now. > > Corinna > > * gdbarch.sh (parse_dwarf2_calling_convention): New method. > * gdbarch.h, gdbarch.c: Re-generate. > * arch-utils.c (default_parse_dwarf2_calling_convention): New function. > * arch-utils.h (default_parse_dwarf2_calling_convention): New extern > declaration. > * dwarf2read.c (read_subroutine_type): Evaluate > DW_AT_calling_convention attribute and call > gdbarch_parse_dwarf2_calling_convention appropriately. The dwarf2read.c part is approved if the rest gets approved.