From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24631 invoked by alias); 5 Oct 2004 20:09:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24553 invoked from network); 5 Oct 2004 20:09:38 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 5 Oct 2004 20:09:38 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i95K9SZk004078 for ; Tue, 5 Oct 2004 16:09:33 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i95K9Sr25269 for ; Tue, 5 Oct 2004 16:09:28 -0400 Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i95K9QPh022309 for ; Tue, 5 Oct 2004 16:09:27 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id E79E11A468F; Tue, 5 Oct 2004 10:11:10 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16738.43902.850632.187540@localhost.redhat.com> Date: Tue, 05 Oct 2004 20:09:00 -0000 To: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: SH 2a - Part 4: Begin using RETURN_VALUE In-Reply-To: <20040909124701.GA7927@cygbert.vinschen.de> References: <20040909124701.GA7927@cygbert.vinschen.de> X-SW-Source: 2004-10/txt/msg00097.txt.bz2 Corinna Vinschen writes: > Hi, > > this is SH 2a patch 4. It does not introduce new functionality, but > instead it converts sh-tdep.c to use RETURN_VALUE instead of > STORE_RETURN_VALUE, EXTRACT_RETURN_VALUE, RETURN_VALUE_ON_STACK and > USE_STRUCT_CONVENTION. > > The old functions are still used and just called from the RETURN_VALUE > implementations. We have two of them, one for fpu and one for nofpu > types. > OK > What this patch does *not* do is this: I would love to rename the > functions sh_default_store/extract_value and sh3e_sh4_store/extract_value > to sh_store/extract_value_nofpu and sh_store/extract_value_fpu. > This would decouple the sense of these functions from the cpu names, > which is rather irritating and wrong anyway. If that's ok, I'd > submit another patch which just performs the renaming. > It wasn't wrong and irritating at the time it was introduced. > Ok, for the sake of completeness, here are the testresults of various > SH cpu types, tested on GNU/Linux host and sh-sim, before and after > applying the whole set of SH 2a patches. I hope the choice of CPUs is > representative enough: > > BEFORE AFTER > ----- ----- > sh-sim/-m2a -- 88 > sh-sim/-m2a-nofpu -- 79 > sh-sim/-m2e 100 100 > sh-sim/-m3 79 79 > sh-sim/-m4 88 88 > sh-sim/-m4/-ml 86 86 > sh-sim/-m4a-single 88 88 > Thanks for providing the test results. Are these with sources.redhat.com sources? Or some internal only tree? What version of gcc? So we have a good reference point. elena