From: John Baldwin <jhb@freebsd.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for catching system calls to native FreeBSD targets.
Date: Fri, 24 Jun 2016 17:57:00 -0000 [thread overview]
Message-ID: <1655704.BrXudgvZLr@ralph.baldwin.cx> (raw)
In-Reply-To: <896dc72b-43d4-2c7d-7fac-7e81431b0922@redhat.com>
On Friday, June 24, 2016 04:52:23 PM Pedro Alves wrote:
> On 06/24/2016 01:24 AM, John Baldwin wrote:
>
> > So I'm not quite sure how to implement an arch-specific target_op.
> > There are various linux_nat_set_* functions that accept a function pointer
> > but then just set a global variable. The amd64 version might have to copy
> > with different ABIs rather than depending on teh i386 gdbarch method, etc.
>
> See amd64-linux-nat.c:amd64_linux_siginfo_fixup for example.
>
> >
> > One option that is a bit smaller in scale would be to move the error
> > in break-catch-syscall.c into linux_child_set_syscall_catchpoint in
> > linux-nat.c. It could return 1 to fail the request if the gdbarch
> > method wasn't present.
>
> That might work indeed.
>
> In any case, I think what you have is reasonable, given the current
> framework. Please do feel free to push what you already have with
> the nits addressed. I did not mean for you to go eliminate
> the gdbarch hook as prerequisite; was really mainly thinking out loud.
> Sorry if it sounded otherwise.
Oh, no worry. I don't mind refactoring when it makes sense. I've gone
ahead and pushed the current patch with nits addressed.
--
John Baldwin
prev parent reply other threads:[~2016-06-24 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 20:58 John Baldwin
2016-06-20 17:10 ` John Baldwin
2016-06-20 22:56 ` Pedro Alves
2016-06-24 0:24 ` John Baldwin
2016-06-24 15:52 ` Pedro Alves
2016-06-24 17:57 ` John Baldwin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1655704.BrXudgvZLr@ralph.baldwin.cx \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox