From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22604 invoked by alias); 25 Jul 2017 22:37:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21845 invoked by uid 89); 25 Jul 2017 22:37:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1146 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 22:37:27 +0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v6PMbHlL025931 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jul 2017 22:37:17 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v6PMbGRQ001113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jul 2017 22:37:17 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v6PMbGPF030344; Tue, 25 Jul 2017 22:37:16 GMT MIME-Version: 1.0 Message-ID: <16527a85-f249-41d0-8fa2-58db1522a2a9@default> Date: Tue, 25 Jul 2017 22:37:00 -0000 From: Weimin Pan To: Cc: , , Subject: Re: [PATCH v4] gdb: ADI support Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2017-07/txt/msg00402.txt.bz2 ----- Original Message ----- > From: simon.marchi@polymtl.ca > To: weimin.pan@oracle.com > Cc: qiyaoltc@gmail.com, jose.marchesi@oracle.com, gdb-patches@sourceware.= org > Sent: Tuesday, July 25, 2017 1:18:00 PM GMT -08:00 US/Canada Pacific > Subject: Re: [PATCH v4] gdb: ADI support > > ... > > > > Given the fact that we need to backport this new feature to older > > gdb's, e.g. > > dev-toolset6, one question is do we need to resort to the linked list > > solution > > if the std list implementation is not available in older gdb versions? > > As of now, > > we have one diversion already - uiout->text ("\n") VS ui_out_text > > (uiout, "\n"). > > Are you talking about Red Hat devtoolset? If so, it seems like it > contains gdb 7.12. As far as I remember, it was possible to build 7.12 > in both C and C++ mode. If you don't need to maintain the ability to > build as C, you should be able to backport a patch using std::list. Yes, it is. It will be a big plus if we can apply the same fix for both old and new versions. Will take a look at std::list or forward_list and=20 use it over the linked list. Thanks.