From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3120 invoked by alias); 22 Apr 2004 15:48:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3068 invoked from network); 22 Apr 2004 15:48:29 -0000 Received: from unknown (HELO sadr.equallogic.com) (66.155.203.134) by sources.redhat.com with SMTP; 22 Apr 2004 15:48:29 -0000 Received: from sadr.equallogic.com (localhost.localdomain [127.0.0.1]) by sadr.equallogic.com (8.12.8/8.12.8) with ESMTP id i3MFmS5G021694 for ; Thu, 22 Apr 2004 11:48:28 -0400 Received: from M30.equallogic.com (m30 [172.16.1.30]) by sadr.equallogic.com (8.12.8/8.12.8) with SMTP id i3MFmSpQ021689; Thu, 22 Apr 2004 11:48:28 -0400 Received: from PKONING.equallogic.com ([172.16.1.120]) by M30.equallogic.com with Microsoft SMTPSVC(5.0.2195.6713); Thu, 22 Apr 2004 11:48:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16519.59728.696000.307468@gargle.gargle.HOWL> Date: Thu, 22 Apr 2004 15:48:00 -0000 From: Paul Koning To: orjan.friberg@axis.com Cc: gdb-patches@sources.redhat.com, eliz@gnu.org, drow@false.org Subject: Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT References: <407282F4.2080602@axis.com> <20040406142228.GA29473@nevyn.them.org> <6654-Thu15Apr2004111217+0300-eliz@gnu.org> <407E8CEF.2050007@axis.com> <407FC69A.1000701@axis.com> <1438-Sat17Apr2004112204+0300-eliz@gnu.org> <4083E930.8040005@axis.com> <4087DFB6.1030801@axis.com> X-OriginalArrivalTime: 22 Apr 2004 15:48:31.0036 (UTC) FILETIME=[42D4EFC0:01C42881] X-SW-Source: 2004-04/txt/msg00527.txt.bz2 >>>>> "Orjan" == Orjan Friberg writes: Orjan> Orjan Friberg wrote: >> Agreed. I am quite happy to live with your suggested solution, >> at least for now. I certainly don't have the audacity to suggest >> such changes should be made to accomodate a target that isn't even >> submitted yet ;) . Orjan> ... which brings me back to the reason for re-opening this Orjan> thread: getting Paul Koning's patch to make read/access Orjan> watchpoints work when HAVE_NONSTEPPABLE_WATCHPOINT is defined Orjan> accepted. Orjan> I did change one thing in Paul's patch, which should be Orjan> highlighted: the change in bpstat_stop_status previously Orjan> applied to bp_watchpoint types also (in addition to Orjan> bp_hardware_watchpoint, bp_read_watchpoint, and Orjan> bp_access_watchpoint), but as far as I can tell Orjan> target_stopped_data_address applies only to hardware-assisted Orjan> watchpoints, not software watchpoints. Maybe that needs to be Orjan> made more clear in the comment. Thanks. I developed the original patch on a platform with hardware watchpoints (MIPS SB-1) so I don't know if it needs to be restricted only to hardware watchpoints or should apply to both types. paul