From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29257 invoked by alias); 22 Apr 2004 15:43:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29233 invoked from network); 22 Apr 2004 15:43:45 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 22 Apr 2004 15:43:45 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 2EA791A4498; Thu, 22 Apr 2004 11:40:31 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16519.59247.93650.941260@localhost.redhat.com> Date: Thu, 22 Apr 2004 15:43:00 -0000 To: Eli Zaretskii Cc: Bob Rossi , gdb-patches@sources.redhat.com, ezannoni@redhat.com Subject: Re: -file-list-exec-source-files In-Reply-To: References: <20040225040059.GB19094@white> <16456.65451.461753.66554@localhost.redhat.com> <20040306155700.GA9439@white> <20040311132508.GA2504@white> <20040329205545.GA26696@white> <20040405214043.GA2052@white> <20040412150620.GA9464@white> <20040420141001.GB4465@white> X-SW-Source: 2004-04/txt/msg00523.txt.bz2 Eli Zaretskii writes: > > Date: Tue, 20 Apr 2004 10:10:01 -0400 > > From: Bob Rossi > > > > Honestly, will someone please review this patch. > > > > Seriously, why is no one looking at this patch? > > It's been over 2 months now! > > Bob, I suggest that you submit another patch that takes into account > all the comments, mainly by Elena and Jason, that still stand after > the discussions back then. Right now, your followups are just > reiterations of Elena's comments and your counter-comments; it's hard > to look at the patch whose many parts are invalidated by discussions. > > If I missed a newer patch you've already sent, please tell me its URL > in the archives, and I will look at it. > > In any case, I think Elena should have the final word, since she is > both responsible for gdb/mi and was the original reviewer of your > submission. But I will try to help her by taking another look at your > code. > Thank you Eli for helping in this, I appreciate the help. Bob, please run gdb_indent.sh (found in the gdb source directory) on your code to make it conform to gnu standards. Also address the issues you feel comfortable fixing. Once that's done we can have another look. > Thanks.