Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [ping] Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp
Date: Wed, 15 Jul 2020 13:53:31 -0600	[thread overview]
Message-ID: <164a4e8e-ddc4-d97c-75dd-377f4be35630@codesourcery.com> (raw)
In-Reply-To: <6bc2b01e-3807-77b9-7d1e-d7f6a7875e49@codesourcery.com>

Ping?  I'd like to get this patch into the GDB 10 branch.

https://sourceware.org/pipermail/gdb-patches/2020-June/169865.html

On 6/24/20 7:35 PM, Sandra Loosemore wrote:
> This patch fixes a group of failures in gdb.base/shell.exp on Windows 
> host due to assumptions that GDB is launching a POSIX-like shell.  On 
> Windows, we get CMD.EXE instead.
> 
> There is a potential second group of failures on Windows host not 
> addressed by this patch, due to the dependence of some of these tests on 
> utilities like wc, sed, and grep.  These tests happen to work for me 
> because the test harness connects to the remote host using Cygwin ssh 
> and both GDB and CMD.EXE inherit the PATH setting from the parent Cygwin 
> shell.  I don't know if disabling those tests on Windows host too is 
> appropriate, or again if this is an instance of badly-designed tests 
> that could be rewritten to avoid those dependencies.  WDYT?
> 
> -Sandra



  parent reply	other threads:[~2020-07-15 19:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25  1:35 Sandra Loosemore
2020-06-25 17:32 ` Christian Biesinger
2020-06-25 17:57   ` Sandra Loosemore
2020-06-25 18:07     ` Eli Zaretskii
2020-06-25 19:35       ` Sandra Loosemore
2020-06-26  7:08         ` Eli Zaretskii
2020-06-26 22:22           ` Sandra Loosemore
2020-06-25 22:36     ` Christian Biesinger
2020-07-15 19:53 ` Sandra Loosemore [this message]
2020-07-16  2:41   ` [ping] " Simon Marchi
2020-07-16 16:44     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164a4e8e-ddc4-d97c-75dd-377f4be35630@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox