Re: [PATCH v5 2/2] gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp

Kevin Buettner via Gdb-patches
2022-03-18T20:07:51Z

I'm seeing a problem with this commit:

1dbf27133db gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp

:

FAIL: gdb.base/run-after-attach.exp: can spawn for attach

Here's the relevant portion of the log file:

Running /mesquite2/sourceware-git/f35-master/bld/../../worktree-master/gdb/testsuite/gdb.base/run-after-attach.exp ...
Executing on host: gcc -fdiagnostics-color=never -c -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.c (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fdiagnostics-color=never -c -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.c
get_compiler_info: gcc-11-2-1
Executing on host: gcc -fno-stack-protector /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.c -fdiagnostics-color=never -w -g -lm -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.x (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fno-stack-protector /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.c -fdiagnostics-color=never -w -g -lm -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.x
builtin_spawn /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.x
builtin_spawn /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/../../gdb/gdb -nw -nx -data-directory /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/../data-directory -iex set height 0 -iex set width 0
GNU gdb (GDB) 12.0.50.20220318-git
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
(gdb) set height 0
(gdb) set width 0
(gdb) attach 184257
Attaching to process 184257
Reading symbols from /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/.nfs0000000002713c210000000a...
Reading symbols from /lib64/libm.so.6...
Reading symbols from /usr/lib/debug/usr/lib64/libm.so.6-2.34-28.fc35.x86_64.debug...
Reading symbols from /lib64/libc.so.6...
Reading symbols from /usr/lib/debug/usr/lib64/libc.so.6-2.34-28.fc35.x86_64.debug...
Reading symbols from /lib64/ld-linux-x86-64.so.2...
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
__GI___clock_nanosleep (clock_id=clock_id@entry=0, flags=flags@entry=0, req=req@entry=0x7ffc4d0e2210, rem=rem@entry=0x7ffc4d0e2210) at ../sysdeps/unix/sysv/linux/clock_nanosleep.c:71
71 return -r;
(gdb) FAIL: gdb.base/run-after-attach.exp: can spawn for attach

The attach appears to have worked. I think that this case was
simply overlooked in the recent changes to can_spawn_for_attach.

Kevin