Re: [PATCH v5 0/2] Modify can_spawn_for_attach

Simon Marchi via Gdb-patches
2022-03-01T14:13:18Z

On 2022-02-28 09:36, Simon Marchi via Gdb-patches wrote:
> On 2022-02-28 01:59, Tiezhu Yang wrote:
>>
>>
>> On 02/23/2022 10:45 AM, Tiezhu Yang wrote:
>>> v5:
>>>   -- Use "unsupported" instead of "untested" in patch #1,
>>>      suggested by Simon Marchi, thank you.
>>>
>>> v4:
>>>   -- Add patch #1 to print explicit test result for some test.
>>>   -- Modify patch #2 suggested by Simon Marchi, thank you.
>>>
>>> Tiezhu Yang (2):
>>>   gdb: testsuite: print explicit test result in can_spawn_for_attach
>>>   gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp
>>>
>>>  gdb/testsuite/lib/gdb.exp | 46 +++++++++++++++++++++++++++++++++++++++-------
>>>  1 file changed, 39 insertions(+), 7 deletions(-)
>>>
>>
>> Hi,
>>
>> I modified the patches as you suggested.
>> Any more comments?
>> Can I push this patchset to the master?
>
> Yeah, please go ahead, thanks.
>
> Simon

Actually, this causes the following test failures:

FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt)

Can you please take a look?

Thanks,

Simon