From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16521 invoked by alias); 16 Feb 2004 18:11:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16507 invoked from network); 16 Feb 2004 18:11:27 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 16 Feb 2004 18:11:27 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id D62411A448A; Mon, 16 Feb 2004 13:07:11 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16433.1743.781290.240346@localhost.redhat.com> Date: Mon, 16 Feb 2004 18:11:00 -0000 To: mec.gnu@mindspring.com (Michael Elizabeth Chastain) Cc: ezannoni@redhat.com, fedor@doc.com, cagney@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc In-Reply-To: <20040209215812.6112F4B363@berman.michael-chastain.com> References: <20040209215812.6112F4B363@berman.michael-chastain.com> X-SW-Source: 2004-02/txt/msg00413.txt.bz2 Michael Elizabeth Chastain writes: > The filenames are a problem because gdb1237-1280-main.c > and gdb1237-1280.c are not 8.3 unique. > > You either have to make them 8.3 unique (preferred) or > add lines to config/djgpp/fnchange.lst. > I created a new PR to include both problems and use that new number. PR/1555. > For the kfail's, please use more specific patterns than just > ".*$gdb_prompt $". kfail's should be for known bugs, which means > there should be known-bad output. If the output doesn't match a > specific known-bad output, then it means that gdb has regressed > even more, and the KFAIL turns into a FAIL (this does happen). > I am not sure what to do here, except start adding patterns. > You don't need to call get_compiler_info unless you use one of > these functions or data symbols later: test_compiler_info, > gcc_compiled, hp_cc_compiler, hp_aCC_compiler, signed_keyword_not_used. > it is using gcc_compiled to figure out the flags to build the shlibs. > I missed the beginning of the thread, but it helps to say what > system(s) you tested it on (so when it breaks on a different system > later, it makes it easier to figure out what is wrong ... morbid > but true). > Adam? I'd like to close this thread and get the test in. elena