From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30584 invoked by alias); 16 Feb 2004 20:54:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30470 invoked from network); 16 Feb 2004 20:54:36 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 16 Feb 2004 20:54:36 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 303571A448A; Mon, 16 Feb 2004 15:50:25 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16433.11537.105919.97207@localhost.redhat.com> Date: Mon, 16 Feb 2004 20:54:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/symbol readers] Clean up setting symbols' names In-Reply-To: <20040216193453.GA1667@nevyn.them.org> References: <20040216193453.GA1667@nevyn.them.org> X-SW-Source: 2004-02/txt/msg00430.txt.bz2 Daniel Jacobowitz writes: > This patch does a couple of related things. > > 1. It adds a macro, SYMBOL_SET_LINKAGE_NAME, which is used to set a > symbol's name when the name should not be demangled. Used for things like > typedefs whose name comes from debug info. I did not change anything > related to memory allocation when I did this - though in hpread I found a > few inconsistencies. > > 2. It makes hpread use SYMBOL_SET_NAMES. It contained some fallback code > to use the debug info if demangling failed; I've disabled it, because from > the description it sounds like the right thing to do would be to fix the > demangler instead. I can't tell whether the code is currently used or not, > so I would appreciate HP/UX testing for this patch. > > In the process I also kill a couple of DEPRECATED_SYMBOL_NAME uses, and the > redundant function add_psymbol_with_dem_name_to_list. > > No testsuite changes with DWARF2 or stabs+ on i386-linux. OK? > NO. There are way too many unrelated changes in this patch. The changes to hpread to use SYMBOL_SET_NAMES should be independent. However you are also changing the logic of the code in a few places, not just mechanically replacing things. You are changing printf's, deleting functions, etc etc. You say there are no regression on i386-linux, did you test on hpux? The objfiles and symfile changes are also logically separate. The SYMBOL_SET_LINKAGE_NAME macro can also be a separate thing. I shouldn't spend time reminding you of this.