Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] sh-tdep.c: Define only the minimal register set in sh_generic_register_name
Date: Mon, 16 Feb 2004 15:43:00 -0000	[thread overview]
Message-ID: <16432.58389.45723.945873@localhost.redhat.com> (raw)
In-Reply-To: <20040212172905.GF3854@cygbert.vinschen.de>

Corinna Vinschen writes:
 > Hi,
 > 
 > while looking into the sh_generic_register_name function, I began to wonder
 > why that function defines a register set, which is not exactly generic,
 > but instead gives a name to all 59 register entries.  Many of them are
 > only correct on CPUs with FPU and/or register banks. 
 > 
 > IMHO, the generic_name function should only define the maximum common
 > register set, which is the same as the one for the basic sh CPU variant.
 > 
 > Therefore I'd like to propose the following patch, which does exactly
 > that.  An alternative approach would be, to remove the
 > sh_generic_register_name entirely and use sh_sh_register_name instead.
 > 

Your are right. I would prefer to just get rid of the function
entirely.  It is already the same as the sh3e_register_name. And after
the change it would duplicate the sh_register_name. No point in
keeping it around.

elena


  reply	other threads:[~2004-02-16 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-12 17:29 Corinna Vinschen
2004-02-16 15:43 ` Elena Zannoni [this message]
2004-02-16 16:04   ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16432.58389.45723.945873@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox